[Devel] Tweak /proc/ipmi removal

Alexey Dobriyan adobriyan at sw.ru
Fri Aug 3 06:30:18 PDT 2007


Driver does
	proc_mkdir("ipmi", NULL);
but
	remove_proc_entry(proc_ipmi_root->name, &proc_root);

This is OK and working if only slightly inconsistent.
Also changing proc_root to NULL will help OpenVZ which has
multiple proc roots and, as we now know, requires matching parents in
such cases.

Please, apply.

Signed-off-by: Alexey Dobriyan <adobriyan at sw.ru>
---

 drivers/char/ipmi/ipmi_msghandler.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -4136,7 +4136,7 @@ static __exit void cleanup_ipmi(void)
 	del_timer_sync(&ipmi_timer);
 
 #ifdef CONFIG_PROC_FS
-	remove_proc_entry(proc_ipmi_root->name, &proc_root);
+	remove_proc_entry(proc_ipmi_root->name, NULL);
 #endif /* CONFIG_PROC_FS */
 
 	driver_unregister(&ipmidriver);




More information about the Devel mailing list