[Devel] Re: [PATCH] cfq: get rid of cfqq hash

[Jens Axboe]

On Tue, Apr 24 2007, Jens Axboe wrote:
> -		if (key != CFQ_KEY_ASYNC)
> +		if (!is_sync)
>  			cfq_mark_cfqq_idle_window(cfqq);
> +		else
> +			cfq_mark_cfqq_sync(cfqq);

Woops, should be

        if (is_sync) {
                cfq_mark_cfqq_idle_window(cfqq);
                cfq_mark_cfqq_sync(cfqq);
        }

of course.

> +static struct cfq_io_context *
> +cfq_get_io_context_noalloc(struct cfq_data *cfqd, struct task_struct *tsk)
> +{
> +	struct cfq_io_context *cic = NULL;
> +	struct io_context *ioc;
> +
> +	ioc = tsk->io_context;
> +	if (ioc)
> +		cic = cfq_cic_rb_lookup(cfqd, ioc);
> +
> +	return cic;
> +}

I'll change that to just call cfq_cic_rb_lookup(), returning NULL for
NULL ioc.

-- 
Jens Axboe