[Devel] Re: [PATCH] Show slab memory usage on OOM and SysRq-M (v2)
Pavel Emelianov
xemul at sw.ru
Tue Apr 17 23:41:45 PDT 2007
Dave Hansen wrote:
> On Tue, 2007-04-17 at 19:34 +0400, Pavel Emelianov wrote:
>> +#define SHOW_TOP_SLABS 10
>
> Real minor nit on this one: SHOW_TOP_SLABS sounds like a bool. "Should
> I show the top slabs?"
>
> This might be a bit more clear:
>
> #define TOP_NR_SLABS_TO_SHOW 10
>
> or
>
> #define NR_SLABS_TO_SHOW 10
Agree :) Will fix in a moment.
>
> -- Dave
>
>
More information about the Devel
mailing list