[Devel] Re: [ckrm-tech] [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers

[Paul Menage]

On 4/10/07, Srivatsa Vaddagiri <vatsa at in.ibm.com> wrote:
>
> Is the first argument into all the callbacks, struct container_subsys *ss,
> necessary?

I added it to support library-like abstractions - where one subsystem
can have its container callbacks and file accesses all handled by a
library which converts to a higher-level abstraction. See the
res_group example patch to see how it can be used.

>
> > +struct container_subsys cpuset_subsys = {
> > +     .name = "cpuset",
> > +     .create = cpuset_create,
> > +     .destroy  = cpuset_destroy,
> > +     .can_attach = cpuset_can_attach,
> > +     .attach = cpuset_attach,
> > +     .populate = cpuset_populate,
> > +     .subsys_id = cpuset_subsys_id,
> > +     .early_init = 1,
> > +};
>
> We seem to be missing a register call here as well ..

Registration is done at compile time in the new patch set, thanks to
the static declaration of subsystems and subsystem ids.