[Devel] Re: [PATCH 3/7] Containers (V8): Add generic multi-subsystem API to containers

Srivatsa Vaddagiri vatsa at in.ibm.com
Fri Apr 6 21:18:51 PDT 2007


On Fri, Apr 06, 2007 at 04:32:24PM -0700, menage at google.com wrote:
> +static int attach_task(struct container *cont, struct task_struct *tsk)
>  {

[snip]

> +	task_lock(tsk);

You need to check here if task state is PF_EXITING and fail with
-ESRCH if so? Otherwise we risk breaking refcount on
init_container_group.

> +	rcu_assign_pointer(tsk->containers, newcg);
> +	task_unlock(tsk);

-- 
Regards,
vatsa




More information about the Devel mailing list