[Devel] Re: [patch02/05]: Containers(V2)- Generic Linux kernel changes

Andi Kleen ak at suse.de
Wed Sep 20 04:27:33 PDT 2006


Rohit Seth <rohitseth at google.com> writes:
>  					 */
> +#ifdef CONFIG_CONTAINERS
> +	struct container_struct *ctn; /* Pointer to container, may be NULL */
> +#endif

I still don't think it's a good idea to add a pointer to struct page for this.
This means any kernel that enables the config would need to carry this significant
overhead, no matter if containers are used to not.

Better would be to store them in some other data structure that is only
allocated on demand or figure out a way to store them in the sometimes
not all used fields in struct page.

BTW your patchkit seems to be also in wrong order in that when 02 is applied
it won't compile.

-Andi




More information about the Devel mailing list