[Devel] Re: [ckrm-tech] [patch 0/5]-Containers: Introduction

Balbir Singh balbir at in.ibm.com
Mon Sep 18 11:08:05 PDT 2006


Rohit Seth wrote:
> On Mon, 2006-09-18 at 18:57 +0530, Balbir Singh wrote:
>> Rohit Seth wrote:
>>
>>> Below is a one line description for patches that will follow:
>>>
>>> [patch01]: Documentation on how to use containers
>>> (Documentation/container.txt)
>>>
>>> [patch02]: Changes in the generic part of kernel code
>>>
>>> [patch03]: Container's interface with configfs
>>>
>>> [patch04]: Core container support
>>>
>>> [patch05]: Over the limit memory handler.
>>>
>> Hi, Rohit,
>>
>> The patches are hard to follow - are they diff'ed with Naurp?
>> At certain places I cannot figure out which function has changed.
>>
> 
> They are without p option so the function name is not there. Though
> there is only one patch 02 of 05 that modifies existing code.  And that
> too almost all single line changes are starting with container API
> container_*  Please let me know if there is something specific that is
> not clear.
> 

Patch 02 is hard to read. I was trying to understand the changes made
in the patch. Patch 01 is trivial, I got stuck at 02.

> I will send the next version of patches and I will include -p option as
> well.
> 
> thanks,
> -rohit
> 

-- 
	Warm Regards,
	Balbir Singh,
	Linux Technology Center,
	IBM Software Labs




More information about the Devel mailing list