[Devel] Re: [RFC][PATCH] Add child reaper to struct pspace

[Kirill Korotaev]

Sukadev Bhattiprolu wrote:

[...skip...]

> @@ -857,7 +858,7 @@ fastcall NORET_TYPE void do_exit(long co
>  		panic("Aiee, killing interrupt handler!");
>  	if (unlikely(!tsk->pid))
>  		panic("Attempted to kill the idle task!");
> -	if (unlikely(tsk == child_reaper))
> +	if (unlikely(tsk == tsk->pspace->child_reaper))
>  		panic("Attempted to kill init!");
this panic is wrong here.

My HO is that termination of init task
should terminate all the other tasks in pspace.
Otherwise you have too select some one else to be child_reaper
and actually there is no good choice here as no one except init
is going to wait() for children.

p.s. can you enumerate these patches please?
since I failed to find where  struct pspace was introduced...
imho in previous patch set? was that patch set already commited to -mm?

Thanks,
Kirill

_______________________________________________
Containers mailing list
Containers at lists.osdl.org
https://lists.osdl.org/mailman/listinfo/containers