[Devel] Re: [Patch03/05]- Containers: Initialization and Configfs interface

[Björn Steinbrink]

On 2006.09.14 18:41:26 -0700, Rohit Seth wrote:
> +static int __init configfs_container_init(void)
> +{
> +	int ret;
> +
> +	config_group_init(&containerfs_group.cs_subsys.su_group);
> +	init_MUTEX(&containerfs_group.cs_subsys.su_sem);
> +	ret = configfs_register_subsystem(&containerfs_group.cs_subsys);
> +
> +	if (ret) 
> +		printk(KERN_ERR "Error %d while registering container subsystem\n", ret);
> +	else {
> +		container_wq = create_workqueue("Kcontainerd");
> +		if (container_wq == NULL) {
> +			ret = -ENOMEM;
> +			printk(KERN_ERR "Unable to create Container controllers");

Shouldn't the subsystem be unregistered here?

> +		}
> +	}
> +	return ret;
> +}

Regards,
Björn