[Devel] Re: [PATCH] iptables compat code error way & module refcounting fix

Patrick McHardy kaber at trash.net
Mon Oct 30 08:04:43 PST 2006


Dmitry Mishin wrote:
> On Monday 30 October 2006 18:45, Patrick McHardy wrote:
> 
>>This doesn't look right, if we fail at xt_alloc_table_info for
>>example the module references are not released.
> 
> module references will be released because of 'goto out;' line just after 
> xt_compat_unlock() - it is missed because of standard +-3 lines patch 
> context, sorry.

You're right, I misread the code. Applied, thanks.




More information about the Devel mailing list