[Devel] Re: [PATCH 2.6.19-rc3] VFS: missing unused dentry in prune_dcache()

David Howells dhowells at redhat.com
Fri Oct 27 07:24:33 PDT 2006


Vasily Averin <vvs at sw.ru> wrote:

> +		/* Inserting dentry to tail of the list leads to cycle */
> + 		list_add(&dentry->d_lru, &dentry_unused);
> +		dentry_stat.nr_unused++;

I'd phrase that comment differently: "Insert dentry at the head of the list as
inserting at the tail leads to a cycle".

But other than that:

Acked-By: David Howells <dhowells at redhat.com>




More information about the Devel mailing list