[Devel] Re: [Q] missing unused dentry in prune_dcache()?

David Howells dhowells at redhat.com
Thu Oct 26 07:07:32 PDT 2006


Vasily Averin <vvs at sw.ru> wrote:

> I would note that in first two hunks you have decremented
> dentry_stat.nr_unused correctly, under dcache_lock. Probably it's better to
> count freed dentries only in third case and corrects dentry_stat.nr_unused
> value inside shrink_dcache_for_umount_subtree() function before return.

Maybe, maybe not.  This way we only touch the dentry_stat cacheline once, if
at all.  I'm not sure it'd make much difference though.

David




More information about the Devel mailing list