[Devel] Re: [PATCH] block layer: elv_iosched_show should get elv_list_lock

Jens Axboe jens.axboe at oracle.com
Wed Oct 11 04:23:14 PDT 2006


On Wed, Oct 11 2006, Vasily Tarasov wrote:
> elv_iosched_show function iterates other elv_list,
> hence elv_list_lock should be got.

Indeed, that's a bug. Thanks!

> Also the question is: in elv_iosched_show, elv_iosched_store
> q->elevator->elevator_type construction is used without locking
> q->queue_lock.  Is it expected?..

As long as the queue doesn't go away, we should be safe enough.

-- 
Jens Axboe




More information about the Devel mailing list