[Devel] Re: [PATCH] pata_artop: fix "& (1 >>" typo

Alan Cox alan at redhat.com
Fri Nov 10 08:25:35 PST 2006


On Fri, Nov 10, 2006 at 10:52:46PM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan at openvz.org>

Acked-by: Alan Cox <alan at redhat.com>

> ---
> 
>  drivers/ata/pata_artop.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
> @@ -92,7 +92,7 @@ static int artop6260_pre_reset(struct at
>  		return -ENOENT;
>  
>  	pci_read_config_byte(pdev, 0x49, &tmp);
> -	if (tmp & (1 >> ap->port_no))
> +	if (tmp & (1 << ap->port_no))
>  		ap->cbl = ATA_CBL_PATA40;
>  	else
>  		ap->cbl = ATA_CBL_PATA80;

-- 
    "People who choose variable names like htlbpagek SHOULD be sent to
             produce a street map of R'Lyeh.  On site."
			-- Al Viro




More information about the Devel mailing list