[Devel] Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces

[Sam Vilain]

Serge E. Hallyn wrote:

>--- a/arch/alpha/kernel/osf_sys.c
>+++ b/arch/alpha/kernel/osf_sys.c
>@@ -402,15 +402,15 @@ osf_utsname(char __user *name)
> 
> 	down_read(&uts_sem);
> 	error = -EFAULT;
>-	if (copy_to_user(name + 0, system_utsname.sysname, 32))
>+	if (copy_to_user(name + 0, utsname()->sysname, 32))
> 		goto out;
>diff --git a/arch/i386/kernel/sys_i386.c b/arch/i386/kernel/sys_i386.c
>index 8fdb1fb..4af731d 100644
>--- a/arch/i386/kernel/sys_i386.c
>+++ b/arch/i386/kernel/sys_i386.c
>@@ -210,7 +210,7 @@ asmlinkage int sys_uname(struct old_utsn
> 	if (!name)
> 		return -EFAULT;
> 	down_read(&uts_sem);
>-	err=copy_to_user(name, &system_utsname, sizeof (*name));
>+	err=copy_to_user(name, utsname(), sizeof (*name));
> 	up_read(&uts_sem);
> 	return err?-EFAULT:0;
> }
>  
>

The semaphore (uts_sem) should be moved in the uts_ns structure, no?

It's probably low impact enough to keep it as it is, though. Just a tad
untidy.

Sam.