[Devel] Re: [PATCH 1/9] namespaces: add nsproxy

[Sam Vilain]

Serge E. Hallyn wrote:

>@@ -1585,7 +1591,15 @@ asmlinkage long sys_unshare(unsigned lon
> 
> 	if (new_fs || new_ns || new_sigh || new_mm || new_fd || new_ulist) {
> 
>+		old_nsproxy = current->nsproxy;
>+		new_nsproxy = dup_namespaces(old_nsproxy);
>+		if (!new_nsproxy) {
>+			err = -ENOMEM;
>+			goto bad_unshare_cleanup_semundo;
>+		}
>+
> 		task_lock(current);
>  
>

We'll get lots of duplicate nsproxy structures before we move all of the
pointers for those subsystems into it. Do we need to dup namespaces on
all of those conditions?

Sam.