[Devel] Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)

[Arjan van de Ven]

On Fri, 2006-03-10 at 08:59 +0000, Al Viro wrote:
> On Fri, Mar 10, 2006 at 09:46:25AM +0100, Arjan van de Ven wrote:
> > On Fri, 2006-03-10 at 11:46 +0300, Kirill Korotaev wrote:
> > > Andrew,
> > > 
> > > Fixed both comments from Al Viro (thanks, Al):
> > > - should have a separate helper
> > > - should pass 0 instead of GFP_KERNEL in page_symlink()
> > 
> > >  
> > > +	page = find_or_create_page(mapping, 0,
> > > +			mapping_gfp_mask(mapping) | gfp_mask);
> > 
> > 
> > 
> > this does not work; GFP_NOFS has a bit *LESS* than GFP_KERNEL, not a bit
> > more. As such a | operation isn't going to be useful....
> > 
> > (So I think that while Al's intention was good, the implication of it
> > isn't ;)
> 
> s/|/^/ and accept my apologies...

I think you mean
& ~() 

since xor... can flip it on if it was off after all