[Devel] Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside

[Al Viro]

On Fri, Mar 10, 2006 at 11:08:29AM +0300, Kirill Korotaev wrote:
> +	page = find_or_create_page(mapping, 0,
> +			mapping_gfp_mask(mapping) | gfp_mask);

> +int page_symlink(struct inode *inode, const char *symname, int len)
> +{
> +	return __page_symlink(inode, symname, len, GFP_KERNEL);

s/GFP_KERNEL/0/; if somebody has e.g. GFP_NOFS in their mapping flags,
you end up breaking their code.  We really pass extra flags to be added
to default ones; page_symlink() should pass 0.