[Devel] RE: [SCSI] 3w-9xxx: kmap_atomic in twa_scsiop_execute_scsi

Adam Radford aradford at amcc.com
Mon Jun 5 11:23:08 PDT 2006


Vasily,

I actually didn't forget this.  I think it isn't needed.  The reason
being
that in scsi.c: scsi_dispatch_command(), where hostt->queuecommand() is
called,
there is a spin_lock_irqsave()/spin_unlock_irqrestore() wrapper in
there, disabling
interrupts.

-Adam

-----Original Message-----
From: Vasily Averin [mailto:vvs at sw.ru] 
Sent: Sunday, June 04, 2006 1:49 AM
To: adam radford; linuxraid
Cc: James Bottomley; Linux Kernel Mailing List;
linux-scsi at vger.kernel.org; devel at openvz.org; Andrew Morton
Subject: [SCSI] 3w-9xxx: kmap_atomic in twa_scsiop_execute_scsi

Hello Adam,

you have fixed recently potential memory corruption, kmap_atomic issue
in 3w-9xxx driver, however it seems for me you have forgotten to fix the
same issue in yet another similar place, in twa_scsiop_execute_scsi()
function.

Signed-off-by: Vasily Averin <vvs at sw.ru>

Thank you,
	Vasily Averin

SWsoft Virtuozzo/OpenVZ Linux kernel team




More information about the Devel mailing list