[Devel] Re: [xfs-masters] [PATCH] xfs: add newline in debug messages

[Eric Sandeen]

Alexey Dobriyan wrote:
> cmn_err(CE_DEBUG, ...); doesn't add newline for you.

The patch looks about right to me.  This -is- how it was -intended- to 
be used.

However, the no-newline behavior is so rarely used that I almost wonder 
if it'd be more straightforward to drop it, and instead use sprintf or 
something to construct those strings... otherwise I'm sure that future 
CE_DEBUG messages will forget newlines as well.

-Eric