[Devel] [patch 06/20] [Network namespace] Move the nsproxy NULL affection

[Cedric Le Goater]

dlezcano at fr.ibm.com wrote:
> Signed-off-by: Daniel Lezcano <dlezcano at fr.ibm.com>
> 
> ---
> 
>  kernel/nsproxy.c |    2 +-
>  1 files changed, 1 insertion(+), 1 deletion(-)
> 
> Index: 2.6.19-rc6-mm2/kernel/nsproxy.c
> ===================================================================
> --- 2.6.19-rc6-mm2.orig/kernel/nsproxy.c
> +++ 2.6.19-rc6-mm2/kernel/nsproxy.c
> @@ -54,10 +54,10 @@ void exit_task_namespaces(struct task_st
>  {
>  	struct nsproxy *ns = p->nsproxy;
>  	if (ns) {
> +		put_nsproxy(ns);
>  		task_lock(p);
>  		p->nsproxy = NULL;
>  		task_unlock(p);
> -		put_nsproxy(ns);
>  	}
>  }

this is a no no.

C.