[Devel] Re: [PATCH 4/6] BC: user interface (syscalls)

[Alexey Dobriyan]

On Wed, Aug 23, 2006 at 03:06:05PM +0400, Kirill Korotaev wrote:
> --- ./kernel/bc/sys.c.ve3
> +++ ./kernel/bc/sys.c

> +asmlinkage long sys_set_bclimit(uid_t id, unsigned long resource,
> +		unsigned long *limits)

		unsigned long __user *limits

> +{
> +	int error;
> +	unsigned long flags;
> +	struct beancounter *bc;
> +	unsigned long new_limits[2];
> +
> +	error = -EPERM;
> +	if(!capable(CAP_SYS_RESOURCE))
> +		goto out;
> +
> +	error = -EINVAL;
> +	if (resource >= BC_RESOURCES)
> +		goto out;
> +
> +	error = -EFAULT;
> +	if (copy_from_user(&new_limits, limits, sizeof(new_limits)))
> +		goto out;

> +int sys_get_bcstat(uid_t id, unsigned long resource,
> +		struct bc_resource_parm *uparm)

				__user *uparm
> +{
> +	int error;
> +	unsigned long flags;
> +	struct beancounter *bc;
> +	struct bc_resource_parm parm;
> +
> +	error = -EINVAL;
> +	if (resource > BC_RESOURCES)
> +		goto out;
> +
> +	error = -ENOENT;
> +	bc = beancounter_findcreate(id, 0);
> +	if (bc == NULL)
> +		goto out;
> +
> +	spin_lock_irqsave(&bc->bc_lock, flags);
> +	parm = bc->bc_parms[resource];
> +	spin_unlock_irqrestore(&bc->bc_lock, flags);
> +	put_beancounter(bc);
> +
> +	error = 0;
> +	if (copy_to_user(uparm, &parm, sizeof(parm)))
> +		error = -EFAULT;