[Devel] Re: [PATCH 2/7] UBC: core (structures, API)

Andrey Savochkin saw at sw.ru
Fri Aug 18 00:35:25 PDT 2006


On Thu, Aug 17, 2006 at 10:31:37PM -0700, Andrew Morton wrote:
> On Thu, 17 Aug 2006 15:53:40 +0400
> Kirill Korotaev <dev at sw.ru> wrote:
> 
> > >>+struct user_beancounter
> > >>+{
> > >>+	atomic_t		ub_refcount;
> > >>+	spinlock_t		ub_lock;
> > >>+	uid_t			ub_uid;
> > > 
> > > 
> > > Why uid?  Will it be possible to club processes belonging to different
> > > users to same bean counter.
> > oh, its a misname. Should be ub_id. it is ID of user_beancounter
> > and has nothing to do with user id.
> 
> But it uses a uid_t.  That's more than a misnaming?

It used to be uid-related in ancient times when the notion of container
hadn't formed up.
"user" part of user_beancounter name has the same origin :)

Now ub_id_t or something like that would be the most logical type.

	Andrey




More information about the Devel mailing list