[Devel] Re: [RFC][PATCH 4/5] utsname namespaces: sysctl hack

Serge E. Hallyn serue at us.ibm.com
Wed Apr 19 10:10:56 PDT 2006


Quoting Kirill Korotaev (dev at sw.ru):
> Serge,
> 
> >Please look closer at the patch.
> >I *am* doing nothing with sysctls.
> >
> >system_utsname no longer exists, and the way to get to that is by using
> >init_uts_ns.name.  That's all this does.
> Sorry for being not concrete enough.
> I mean switch () in the code. Until we decided how to virtualize 
> sysctls/proc, I believe no dead code/hacks should be commited. IMHO.
> 
> FYI, I strongly object against virtualizing sysctls this way as it is 
> not flexible and is a real hack from my POV.

Oops, I forgot that was there!

Sorry.

Yup, I'm fine with leaving that out.  After all, nothing in the
non-debugging patchset allows userspace to clone the utsnamespace yet,
so it's tough to argue that leaving out that switch impacts
functionality :)

I believe Dave is working on a more acceptable sysctl adaptation, though
I'm not sure when he'll have a patch to submit.  In any case, one clear
concise piece at a time.

thanks,
-serge




More information about the Devel mailing list