[Devel] [KERNEL COMMIT]: diff-fairsched-loadbal-20051201

Kirill Korotaev dev at sw.ru
Fri Dec 2 03:13:57 PST 2005


Committed in 022stab052

Patch from Kirill (dev@):
This patch removes warning on load balance.
Balancing is racy, and it is not fatal anyhow if
busiest rq is the current one. printk() under
rq->lock can be the much more fatal thing here...
Bug #55290

-------------- next part --------------
--- ./kernel/sched.c.loadbal	2005-11-25 22:04:23.000000000 +0300
+++ ./kernel/sched.c	2005-12-01 13:55:28.000000000 +0300
@@ -2586,10 +2586,8 @@ static int load_balance(vcpu_t this_cpu,
 	 * balancing is inherently racy and statistical,
 	 * it could happen in theory.
 	 */
-	if (unlikely(busiest == this_rq)) {
-		WARN_ON(1);
+	if (unlikely(busiest == this_rq))
 		goto out_balanced;
-	}
 
 	nr_moved = 0;
 	if (busiest->nr_running > 1) {


More information about the Devel mailing list