[Debian] Re: unblock request for vzctl

[Ola Lundqvist]

Hi julien

On Wed, Sep 15, 2010 at 11:37:12PM +0200, Julien Cristau wrote:
> On Tue, Sep 14, 2010 at 06:51:55 +0200, Ola Lundqvist wrote:
> 
> > Hi Julien
> > 
> > On Mon, Sep 13, 2010 at 10:47:26PM +0200, Julien Cristau wrote:
> > > On Mon, Sep 13, 2010 at 22:10:51 +0200, Ola Lundqvist wrote:
> > 
> > ...
> > 
> > > > > Why are you ignoring errors from the init script?
> > > > 
> > > > Good question. It is a practice of mine to make sure that upgrade
> > > > do not fail just because of some issue during the startup. Especially
> > > > important as this one checks for kernel modules which may be provided
> > > > by custom kernels. Do you have a problem with that?
> > > > 
> > > Well, kind of, yeah.  If a service can't start for whatever reason then
> > > I don't think it should be ignored and swept under the carpet.
> > 
> > Ok. As we have the if statement first on whether it should be started
> > or not it should be safe enough. I have also reviewed so that problems like
> > "already started" is safely ignored already.
> > I have removed the "|| true" part of the code now.
> > Uploaded in 3.0.24-7.
> > 
> It's still there in prerm though?

Yes. People should really be able to remove the package regardless of
errors.

> Let me know if you want to upload a -8 for this.  -7 unblocked in the
> mean time.

If you really think it should not be there, then I'll upload -8 as
well, but I'm not sure I wants to. :-)

Thanks a lot for your help in this matter.

Best regards,

// Ola

> Cheers,
> Julien



-- 
 --- Inguza Technology AB --- MSc in Information Technology ----
/  ola at inguza.com                    Annebergsslingan 37        \
|  opal at debian.org                   654 65 KARLSTAD            |
|  http://inguza.com/                Mobile: +46 (0)70-332 1551 |
\  gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9  /
 ---------------------------------------------------------------