[Debian] Re: Solution for #576227
Thorsten Schifferdecker
tsd at debian.systs.org
Tue Sep 7 13:10:52 EDT 2010
Hi Ola,
Hi Kir,
is a shared script for unify the initd scripts for some distros, like rh,
deb etc.
should be moved out of the init.d dir.
@kir: i prefer to move this file to vzlibdir [ $(pkglibdir)/scripts ]
Bye,
Thorsten
--
Thorsten Schifferdecker
OpenVZ Power User
On Tue, 7 Sep 2010 18:35:46 +0200, Ola Lundqvist <ola at inguza.com> wrote:
> Hi Kir
>
> Looks like there are quite a lot of issues to solve...
>
> Taking them one by one.
>
> ola at quartz:~/build/debian/vzctl/vzctl-3.0.24$ lintian -vi ../*.changes
> N: Setting up lab in /tmp/rRewEVamSw ...
> N: Processing 3 packages...
> N: ----
> N: Processing changes file vzctl_3.0.24-4_i386 (version 3.0.24-4) ...
> N: ----
> N: Processing source package vzctl (version 3.0.24-4) ...
> N: ----
> N: Processing binary package vzctl (version 3.0.24-4) ...
> W: vzctl: script-in-etc-init.d-not-registered-via-update-rc.d
> /etc/init.d/vzfunctions
> N:
> N: The package installs an /etc/init.d script which is not registered
in
> N: the postinst script. This is usually a bug, unless you omit the
links
> N: intentionally for some reason or create the links some other way.
> N:
> N: Severity: normal, Certainty: possible
> N:
>
> Should this be moved to /etc/default/vzfunctions or
> /etc/vz/vzinitfunctions instead?
>
> W: vzctl: init.d-script-missing-lsb-section /etc/init.d/vzfunctions
> N:
> N: This /etc/init.d script does not have an LSB keyword section (or
the
> ###
> N: BEGIN INIT INFO tag is incorrect). This section provides
description
> and
> N: runlevel information in a standard format and provides dependency
> N: information that can be used to parallelize the boot process.
Please
> N: consider adding it.
> N:
> N: Refer to http://wiki.debian.org/LSBInitScripts for details.
> N:
> N: Severity: normal, Certainty: certain
> N:
>
> Solved by moving out that vzfunctions script to somewhere else.
>
> E: vzctl: init.d-script-does-not-implement-required-option
> /etc/init.d/vzfunctions start
> N:
> N: The /etc/init.d scripts have to support the following command line
> N: arguments: start, stop, restart, force-reload.
> N:
> N: Refer to Debian Policy Manual section 9.3.2 (Writing the scripts)
for
> N: details.
> N:
> N: Severity: important, Certainty: certain
> N:
>
> Same here.
>
> E: vzctl: init.d-script-does-not-implement-required-option
> /etc/init.d/vzfunctions stop
>
> Same here.
>
> E: vzctl: init.d-script-does-not-implement-required-option
> /etc/init.d/vzfunctions restart
>
> Same here.
>
> E: vzctl: init.d-script-does-not-implement-required-option
> /etc/init.d/vzfunctions force-reload
>
> Same here.
>
> W: vzctl: script-in-etc-init.d-not-registered-via-update-rc.d
> /etc/init.d/vzeventd
>
> This is something that I have to solve. You do not need to bother about
> that.
>
> W: vzctl: init.d-script-missing-lsb-keyword /etc/init.d/vzeventd
> required-stop
> N:
> N: This /etc/init.d script has an LSB keyword section, but it is
missing
> N: the given required LSB keyword. If the value of this keyword
should
> be
> N: empty, please still include it in the LSB keyword section with an
> empty
> N: value.
> N:
> N: Refer to http://wiki.debian.org/LSBInitScripts for details.
> N:
> N: Severity: normal, Certainty: certain
> N:
>
> Required-start: missing in LSB keyword section.
>
> W: vzctl: init.d-script-missing-lsb-keyword /etc/init.d/vzeventd
> required-start
>
> And Required-stop:
>
> E: vzctl: init.d-script-missing-dependency-on-remote_fs
> /etc/init.d/vzeventd: required-start
> N:
> N: The given init script seems to refer to /usr, possibly using a
file
> or
> N: binary from there. Without a dependency on $remote_fs in
> Required-Start
> N: or Required-Stop, as appropriate, the init script might be run
before
> N: /usr is mounted or after it's unmounted.
> N:
> N: Using Should-Start or Should-Stop to declare the dependency is
> N: conceptually incorrect since the $remote_fs facility is always
> N: available. Required-Start or Required-Stop should be used instead.
> Also,
> N: please note that $all should not be used in Required-Stop, only
> N: Required-Start.
> N:
> N: Refer to http://wiki.debian.org/LSBInitScripts for details.
> N:
> N: Severity: important, Certainty: possible
> N:
> E: vzctl: init.d-script-missing-dependency-on-remote_fs
> /etc/init.d/vzeventd: required-stop
>
> This also seems to be an issue that needs to be solved.
>
> Will you solve all the above, or should I add that myself?
>
> Best regards,
>
> // Ola
>
> On Tue, Sep 07, 2010 at 07:44:13PM +0400, Kir Kolyshkin wrote:
>> The additional stuff I sent is not enough -- apparently I haven't
>> checked that initscript
>> is working on Debian, and it's not (see OpenVZ bug #1632 [1]).
>>
>> I hope to fix that tomorrow, please wait.
>>
>> [1] http://bugzilla.openvz.org/1632
>>
>> On 09/07/2010 03:44 PM, Ola Lundqvist wrote:
>>> Hi Kir
>>>
>>> Thanks a lot! Now the compile works but not the install. Looks like
>>> vzfunctions is not generated from vzfunctions.in...
>>>
>>> make[2]: Entering directory
>>> `/home/ola/build/debian/vzctl/vzctl-3.0.24/etc'
>>> /usr/bin/make -C init.d install-redhat
>>> make[3]: Entering directory
>>> `/home/ola/build/debian/vzctl/vzctl-3.0.24/etc/init.d'
>>> sed -e 's!@'SBINDIR'@!/usr/sbin!g; s!@'PKGCONFDIR'@!/etc/vz!g;
>>> s!@'VPSCONFDIR'@!/etc/vz/conf!g; s!@'PKGDATADIR'@!/usr/share/vzctl!g;
>>> s!@'PKGLIBDIR'@!/usr/lib/vzctl!g;' vz-redhat.in> vz-redhat
>>> /bin/sh /home/ola/build/debian/vzctl/vzctl-3.0.24/install-sh -d
>>> /home/ola/build/debian/vzctl/vzctl-3.0.24/debian/vzctl/etc/init.d
>>> /usr/bin/install -c vzfunctions
>>>
/home/ola/build/debian/vzctl/vzctl-3.0.24/debian/vzctl/etc/init.d/vzfunctions
>>> /usr/bin/install: cannot stat `vzfunctions': No such file or directory
>>> make[3]: *** [install-redhat] Error 1
>>> make[3]: Leaving directory
>>> `/home/ola/build/debian/vzctl/vzctl-3.0.24/etc/init.d'
>>> make[2]: *** [install-redhat] Error 2
>>> make[2]: Leaving directory
>>> `/home/ola/build/debian/vzctl/vzctl-3.0.24/etc'
>>> make[1]: *** [install-redhat] Error 2
>>> make[1]: Leaving directory `/home/ola/build/debian/vzctl/vzctl-3.0.24'
>>> make: *** [install] Error 2
>>>
>>> Looks like this is also needed!:
>>>
>>> ola at quartz:~/build/debian/vzctl/vzctl-3.0.24$ diff -u
>>> etc/init.d/Makefile.am{~,}
>>> --- etc/init.d/Makefile.am~ 2010-09-07 11:53:19.900317676 +0200
>>> +++ etc/init.d/Makefile.am 2010-09-07 13:43:43.628317548 +0200
>>> @@ -23,7 +23,7 @@
>>>
>>> include $(top_srcdir)/pathsubst.am
>>>
>>> -install-redhat: vz-redhat
>>> +install-redhat: vz-redhat vzfunctions vzeventd-redhat
>>> $(mkinstalldirs) $(DESTDIR)$(initddir)
>>> $(INSTALL_SCRIPT) vzfunctions
>>> $(DESTDIR)$(initddir)/vzfunctions
>>> $(INSTALL_SCRIPT) vz-redhat $(DESTDIR)$(initddir)/vz
>>> @@ -33,7 +33,7 @@
>>>
>>> install-debian: install-redhat
>>>
>>> -install-gentoo: vz-gentoo
>>> +install-gentoo: vz-gentoo vzeventd-gentoo
>>> $(mkinstalldirs) $(DESTDIR)$(initddir)
>>> $(INSTALL_SCRIPT) vz-gentoo $(DESTDIR)$(initddir)/vz
>>> $(INSTALL_SCRIPT) vzeventd-gentoo
>>> $(DESTDIR)$(initddir)/vzeventd
>>>
>>>
>>> Best regards,
>>>
>>> // Ola
>>>
>>> Quoting "Kir Kolyshkin"<kir at openvz.org>:
>>>
>>>> On 09/07/2010 02:02 PM, Ola Lundqvist wrote:
>>>>
>>>>> Hi Kir
>>>>>
>>>>> Your suggestion solved that build problem. Thanks a lot for that.
>>>>>
>>>>> I will try to convince the release team about the changes. If I fail
>>>>> I will
>>>>> request help from you. But before that you need to solve the
following
>>>>> issue for me.
>>>>>
>>>>> gcc -DSBINDIR=\"/usr/sbin\" -DPKGCONFDIR=\"/etc/vz\"
>>>>> -DPKGLIBDIR=\"/usr/lib/vzct
>>>>> l\" -Wall -g -O2 -Wall -Wpointer-arith
>>>>> -Wcast-qual -Winline -Wextra -Wcast-align
>>>>> -Wno-unused-parameter
>>>>> -D_FILE_OFFSET_BITS=64 -o .libs/vzeventd vzeventd.o ../s
>>>>>
>>>>> rc/lib/.libs/libvzctl.so
>>>>> vzeventd.o: In function `parse_event':
>>>>> /home/ola/build/debian/vzctl/vzctl-3.0.24/src/vzeventd.c:117:
>>>>> undefined reference to `set_log_ctid'
>>>>> vzeventd.o: In function `read_events':
>>>>> /home/ola/build/debian/vzctl/vzctl-3.0.24/src/vzeventd.c:178:
>>>>> undefined reference to `set_log_ctid'
>>>>> vzeventd.o: In function `daemon_read_events':
>>>>> /home/ola/build/debian/vzctl/vzctl-3.0.24/src/vzeventd.c:205:
>>>>> undefined reference to `set_log_quiet'
>>>>> collect2: ld returned 1 exit status
>>>>>
>>>>> Do you know why that is? Do this patch depend on some other patch as
>>>>> well?
>>>>>
>>>>>
>>>> Yeah, this one:
>>>>
http://git.openvz.org/?p=vzctl;a=commitdiff;h=f3bf51833e4a1533f9f92132d1872d84e106b3cf
>>>>
>>>> Sorry I haven't mentioned it.
>>>>
>>>>
>>>>> // Ola
>>>>>
>>>>> Quoting "Ola Lundqvist"<ola at inguza.com>:
>>>>>
>>>>>
>>>>>> Hi Kir
>>>>>>
>>>>>> autogen.sh do not exist in the released version of the source. It
>>>>>> only exists in git. :-)
>>>>>>
>>>>>> However I found it.
>>>>>>
>>>>>> I missed to run libtoolize and was missing parameters for automake.
>>>>>>
>>>>>> However I think I will have some problem to convince the release
>>>>>> managers about this. The patch is very invasive, especially when we
>>>>>> change the build system...
>>>>>>
>>>>>> Would it be possible for you to take the .tar.gz from Debian, apply
>>>>>> the debian patch, apply the two patches and then run autogen.sh
with
>>>>>> the versions you have. I have a feeling that this will cause a lot
>>>>>> less differences than it do for me with completely different
>>>>>> automake, libtool and autoconf versions.
>>>>>>
>>>>>> The reason why I ask you for this is that I think I will have a
>>>>>> problem to convince the release managers about this already without
>>>>>> the build problem issues.
>>>>>>
>>>>>> Best regards,
>>>>>>
>>>>>> // Ola
>>>>>>
>>>>>> Quoting "Kir Kolyshkin"<kir at parallels.com>:
>>>>>>
>>>>>>
>>>>>>> Try running
>>>>>>> make distclean; ./autogen.sh
>>>>>>>
>>>>>>> It should help.
>>>>>>>
>>>>>>> Ola Lundqvist<ola at inguza.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> Hi again Kir
>>>>>>>
>>>>>>> The problem I end up with after upgrading to a recent version
>>>>>>> of autoconf is the following:
>>>>>>>
>>>>>>> make[3]: Entering directory
>>>>>>> `/home/ola/build/debian/vzctl/t/vzctl-3.0.24/src/lib'
>>>>>>> /bin/sh ../../libtool --tag=CC --mode=compile gcc
>>>>>>> -DPACKAGE_NAME=\"vzctl\" -DPACKAGE_TARNAME=\"vzctl\"
>>>>>>> -DPACKAGE_VERSION=\"3.0.24\" -DPACKAGE_STRING=\"vzctl\ 3.0.24\"
>>>>>>> -DPACKAGE_BUGREPORT=\"devel at openvz.org\" -DPACKAGE_URL=\"\"
>>>>>>> -DPACKAGE=\"vzctl\" -DVERSION=\"3.0.24\" -DSTDC_HEADERS=1
>>>>>>> -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1
>>>>>>> -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1
>>>>>>> -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1
>>>>>>> -DHAVE_DLFCN_H=1 -I. -I../../include -DSBINDIR=\"/usr/sbin\"
>>>>>>> -DPKGCONFDIR=\"/etc/vz\" -DPKGLIBDIR=\"/usr/lib/vzctl\" -Wall -g
>>>>>>> -O2 -Wall -Wpointer-arith -Wcast-qual -Winline -Wextra
-Wcast-align
>>>>>>> -Wno-unused-parameter -D_FILE_OFFSET_BITS=64 -MT cap.lo -MD -MP
-MF
>>>>>>> .deps/cap.Tpo -c -o cap.lo cap.c
>>>>>>> ../../libtool: line 467: CDPATH: command not found
>>>>>>> ../../libtool: line 1145: func_opt_split: command not found
>>>>>>> libtool: Version mismatch error. This is libtool 2.2.6b, but the
>>>>>>> libtool: definition of this LT_INIT comes from an older release.
>>>>>>> libtool: You should recreate aclocal.m4 with macros from libtool
>>>>>>> 2.2.6b
>>>>>>> libtool: and run autoconf again.
>>>>>>>
>>>>>>> So to me it would help a lot of I could have a patch so the only
>>>>>>> thing
>>>>>>> I need to run to make it work is ./configure and then make.
>>>>>>>
>>>>>>> Best regards,
>>>>>>>
>>>>>>> // Ola
>>>>>>>
>>>>>>> On Tue, Sep 07, 2010 at 08:19:24AM +0200, Ola Lundqvist wrote:
>>>>>>>
>>>>>>>
>>>>>>>> Hi Kir
>>>>>>>>
>>>>>>>> I can see in bugzilla that this is now considered to be solved
with
>>>>>>>> the two following patches:
>>>>>>>>
>>>>>>>>
http://git.openvz.org/?p=vzctl;a=commit;h=4cc6257616e1a725650d6b026a42d17cd1c3cce8
>>>>>>>>
http://git.openvz.org/?p=vzctl;a=commit;h=5b35797753892bfa507b2aa0a1207f0c97bba005
>>>>>>>>
>>>>>>>> These two are rather invasive patches and requires the kernel
>>>>>>>> to have this support.
>>>>>>>>
>>>>>>>> I have looked through the patch and can see that the
>>>>>>>> mk_reboot_script
>>>>>>>> code is now removed in the second patch in script.c.
>>>>>>>>
>>>>>>>> But do we remove this entry if it already exists and the kernel
>>>>>>>> support this?
>>>>>>>>
>>>>>>>> Also, did you get an answer from the Kernel maintainers about
>>>>>>>> whether they are allowing this to be solved or not?
>>>>>>>>
>>>>>>>> Also, would anything bad happen in case I apply the patch and the
>>>>>>>> kernel do not support this new functionality?
>>>>>>>>
>>>>>>>> In addition it looks like I have a too old version of autoconf.
>>>>>>>> Can you please send me a patch with the changes after automake
run
>>>>>>>> as
>>>>>>>> well so all the .am file changes take effect? That would help me
>>>>>>>> quite a lot.
>>>>>>>>
>>>>>>>> Best regards,
>>>>>>>>
>>>>>>>> // Ola
>>>>>>>>
>>>>>>>> --
>>>>>>>>
>>>>>>>>
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>
>>
>
> --
> --- Inguza Technology AB --- MSc in Information Technology ----
> / ola at inguza.com Annebergsslingan 37 \
> | opal at debian.org 654 65 KARLSTAD |
> | http://inguza.com/ Mobile: +46 (0)70-332 1551 |
> \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 /
> ---------------------------------------------------------------
> _______________________________________________
> Debian mailing list
> Debian at openvz.org
> https://openvz.org/mailman/listinfo/debian
More information about the Debian
mailing list