<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">сб, 6 июн. 2020 г. в 20:03, Mike Rapoport <<a href="mailto:rppt@linux.ibm.com">rppt@linux.ibm.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The updates of an existing pull request are hard to review because it is<br>
not clear what was changed from the previous version.<br>
It would be easier for reviewers and maintainers to have the PR closed<br>
and then opened again with the updated changes and a brief description<br>
of changes between the versions.<br>
<br>
Add a text to README.md that will emphasize this.<br>
<br>
Signed-off-by: Mike Rapoport <<a href="mailto:rppt@linux.ibm.com" target="_blank">rppt@linux.ibm.com</a>><br>
---<br>
README.md | 2 ++<br>
1 file changed, 2 insertions(+)<br>
<br>
diff --git a/README.md b/README.md<br>
index 6a578b953..6f82c8241 100644<br>
--- a/README.md<br>
+++ b/README.md<br>
@@ -68,6 +68,8 @@ Here are some useful hints to get involved.<br>
* Documentation is always hard, we have [some information](<a href="https://criu.org/Category:Empty_articles" rel="noreferrer" target="_blank">https://criu.org/Category:Empty_articles</a>) that is to be extracted from people's heads into wiki pages as well as [some texts](<a href="https://criu.org/Category:Editor_help_needed" rel="noreferrer" target="_blank">https://criu.org/Category:Editor_help_needed</a>) that all need to be converted into useful articles;<br>
* Feedback is expected on the github issues page and on the [mailing list](<a href="https://lists.openvz.org/mailman/listinfo/criu" rel="noreferrer" target="_blank">https://lists.openvz.org/mailman/listinfo/criu</a>);<br>
* We accept github pull requests and this is the preferred way to contribute to CRIU. If you prefer to send patches by email, you are welcome to send them to [the devel list](<a href="http://criu.org/How_to_submit_patches" rel="noreferrer" target="_blank">http://criu.org/How_to_submit_patches</a>);<br>
+ * Please avoid force pushing updates to an existent pull request. Close the pull request and open a new one with the updated changes.<br></blockquote><div><br></div><div>This makes it hard to track history. When the 2nd version is pushed maintainer should knows that a) it's vN+1 and b) what whas in vN.</div><div>I agree that github PRs suck in many ways though.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+ * Mention what were the changes between different versions of a pull request. It makes reviewers and maintainers life much easier.<br>
* Spread the word about CRIU in [social networks](<a href="http://criu.org/Contacts" rel="noreferrer" target="_blank">http://criu.org/Contacts</a>);<br>
* If you're giving a talk about CRIU -- let us know, we'll mention it on the [wiki main page](<a href="https://criu.org/News/events" rel="noreferrer" target="_blank">https://criu.org/News/events</a>);<br>
<br>
-- <br>
2.25.4<br>
<br>
</blockquote></div></div>