<div dir="ltr">Hi Cyrill,<div><br></div><div>Sure will do the required changes, my bad I was unaware of compell_syscall() implementation, I will be more careful next time. </div><div>I will send the patch ASAP.<br>Thanks for pointing it out. </div><div><br></div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Thu, Mar 21, 2019 at 4:48 PM Cyrill Gorcunov <<a href="mailto:gorcunov@gmail.com">gorcunov@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Sat, Mar 16, 2019 at 02:52:04PM +0000, <a href="mailto:mitulkarnik.92@gmail.com" target="_blank">mitulkarnik.92@gmail.com</a> wrote:<br>
> From: Mitul Karnik <<a href="mailto:mitulkarnik.92@gmail.com" target="_blank">mitulkarnik.92@gmail.com</a>><br>
> <br>
> Fixes #334: Removing Unneeded Assignments<br>
> <br>
> Patch Description:<br>
> Removed return value assignment statements as they are not referenced or used <br>
> anywhere after the assignment is done.<br>
> <br>
> Signed-off-by: Mitul Karnik <<a href="mailto:mitulkarnik.92@gmail.com" target="_blank">mitulkarnik.92@gmail.com</a>><br>
> ---<br>
> compel/arch/s390/src/lib/infect.c | 2 +-<br>
> criu/path.c | 2 +-<br>
> test/zdtm/static/dumpable02.c | 4 ++--<br>
> 3 files changed, 4 insertions(+), 4 deletions(-)<br>
> <br>
> diff --git a/compel/arch/s390/src/lib/infect.c b/compel/arch/s390/src/lib/infect.c<br>
> index 940d0441..b690b812 100644<br>
> --- a/compel/arch/s390/src/lib/infect.c<br>
> +++ b/compel/arch/s390/src/lib/infect.c<br>
> @@ -455,7 +455,7 @@ void *remote_mmap(struct parasite_ctl *ctl,<br>
> if (ptrace_poke_area(pid, &arg_struct, where, sizeof(arg_struct))) {<br>
> pr_err("Can't restore mmap args (pid: %d)\n", pid);<br>
> if (map != 0) {<br>
> - err = compel_syscall(ctl, __NR_munmap, NULL, map,<br>
> + compel_syscall(ctl, __NR_munmap, NULL, map,<br>
> length, 0, 0, 0, 0);<br>
> map = 0;<br>
> }<br>
<br>
This is wrong. You should rather check err and print error message<br>
if __NR_munmap failed.<br>
</blockquote></div>