<div dir="auto">Hi Team,<div dir="auto"><br></div><div dir="auto">Thanks alot for reviewing the patch and apologies for minor issues. Since I am beginning to contribute to CRIU I was unaware of this process. Should I resend the patch with suggested changes ? </div><div dir="auto">Again apologies for being naive. </div><div dir="auto"><br></div><div dir="auto">Regards,</div><div dir="auto">Mitul<br><div dir="auto"><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun 10 Mar, 2019, 15:24 Radostin Stoyanov, <<a href="mailto:rstoyanov1@gmail.com">rstoyanov1@gmail.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
On 10/03/2019 06:36, Mike Rapoport wrote:<br>
> Hi,<br>
><br>
>> Subject: Bugfix 334: Remove unneeded assignments<br>
> On Fri, Mar 08, 2019 at 10:03:29AM +0000, <a href="mailto:mitulkarnik.92@gmail.com" target="_blank" rel="noreferrer">mitulkarnik.92@gmail.com</a> wrote:<br>
>> From: Mitul Karnik <<a href="mailto:mitulkarnik.92@gmail.com" target="_blank" rel="noreferrer">mitulkarnik.92@gmail.com</a>><br>
>><br>
>> Signed-off-by: Mitul Karnik <<a href="mailto:mitulkarnik.92@gmail.com" target="_blank" rel="noreferrer">mitulkarnik.92@gmail.com</a>><br>
> In CRIU we add "Fixes: #<issue>" to the changelog body rather than to the<br>
> subject. Other than that:<br>
><br>
> Reviewed-by: Mike Rapoport <<a href="mailto:rppt@linux.ibm.com" target="_blank" rel="noreferrer">rppt@linux.ibm.com</a>><br>
"Fixes" is also a keyword that is used by GitHub to close the issue, and<br>
there are a few more of them.<br>
<br>
<a href="https://help.github.com/en/articles/closing-issues-using-keywords" rel="noreferrer noreferrer" target="_blank">https://help.github.com/en/articles/closing-issues-using-keywords</a><br>
<br>
>> ---<br>
>> compel/arch/s390/src/lib/infect.c | 2 +-<br>
>> criu/path.c | 2 +-<br>
>> test/zdtm/static/dumpable02.c | 4 ++--<br>
>> 3 files changed, 4 insertions(+), 4 deletions(-)<br>
>><br>
>> diff --git a/compel/arch/s390/src/lib/infect.c b/compel/arch/s390/src/lib/infect.c<br>
>> index 940d0441..b690b812 100644<br>
>> --- a/compel/arch/s390/src/lib/infect.c<br>
>> +++ b/compel/arch/s390/src/lib/infect.c<br>
>> @@ -455,7 +455,7 @@ void *remote_mmap(struct parasite_ctl *ctl,<br>
>> if (ptrace_poke_area(pid, &arg_struct, where, sizeof(arg_struct))) {<br>
>> pr_err("Can't restore mmap args (pid: %d)\n", pid);<br>
>> if (map != 0) {<br>
>> - err = compel_syscall(ctl, __NR_munmap, NULL, map,<br>
>> + compel_syscall(ctl, __NR_munmap, NULL, map,<br>
>> length, 0, 0, 0, 0);<br>
>> map = 0;<br>
>> }<br>
>> diff --git a/criu/path.c b/criu/path.c<br>
>> index 70b0c472..22a89a4a 100644<br>
>> --- a/criu/path.c<br>
>> +++ b/criu/path.c<br>
>> @@ -99,7 +99,7 @@ char *mnt_get_sibling_path(struct mount_info *m,<br>
>> rpath++;<br>
>> <br>
>> if (rpath[0] != '\0')<br>
>> - off = snprintf(path, len, "/%s", rpath);<br>
>> + snprintf(path, len, "/%s", rpath);<br>
>> <br>
>> return buf;<br>
>> }<br>
>> diff --git a/test/zdtm/static/dumpable02.c b/test/zdtm/static/dumpable02.c<br>
>> index bd632e13..024371bd 100644<br>
>> --- a/test/zdtm/static/dumpable02.c<br>
>> +++ b/test/zdtm/static/dumpable02.c<br>
>> @@ -143,8 +143,8 @@ int main(int argc, char **argv)<br>
>> return 1;<br>
>> }<br>
>> <br>
>> - ret = execl(argv[0], "dumpable_server", NULL);<br>
>> - pr_perror("could not execv %s as a dumpable_server", argv[0]);<br>
>> + execl(argv[0], "dumpable_server", NULL);<br>
>> + pr_perror("could not execv %s as a dumpable_server\nError No: %d", argv[0], errno);<br>
>> return 1;<br>
>> }<br>
>> <br>
>> -- <br>
>> 2.17.1<br>
>><br>
>> _______________________________________________<br>
>> CRIU mailing list<br>
>> <a href="mailto:CRIU@openvz.org" target="_blank" rel="noreferrer">CRIU@openvz.org</a><br>
>> <a href="https://lists.openvz.org/mailman/listinfo/criu" rel="noreferrer noreferrer" target="_blank">https://lists.openvz.org/mailman/listinfo/criu</a><br>
>><br>
<br>
</blockquote></div>