<div dir="ltr"><div dir="ltr"><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
> Is these hunk really an indentation fix? we have many places of:<br>
><br>
Thank you for asking, this patch is actually fixing the indentation on<br>
several places, and since<br>
<a href="https://criu.org/How_to_submit_patches#Edit_the_source_code" rel="noreferrer" target="_blank">https://criu.org/How_to_submit_patches#Edit_the_source_code</a> recommends<br>
to follow Linux kernel coding style<br>
<<a href="https://www.kernel.org/doc/Documentation/process/coding-style.rst" rel="noreferrer" target="_blank">https://www.kernel.org/doc/Documentation/process/coding-style.rst</a>>,<br>
which states a preferred way for placing braces and spaces, and gives<br>
the following example:<br>
<br>
if (x == y) {<br>
..<br>
} else if (x > y) {<br>
...<br>
} else {<br>
....<br>
}<br>
<br>
I though that it would be good to make the code consistent and follow<br>
this practice. However, I don't have a string opinion about this and I<br>
will be happy to send a patch to revert these changes.<br><br></blockquote><div><br></div><div><div>Thanks for you explanation!</div><div><br></div><div>Now I see that
to follow Linux coding style we actually need to fix other 23 places
where we partially skip brackets only in a single branch according to:<br></div><div><br></div><div>"Do not unnecessarily use braces where a single statement will do.<br>This does not apply if only one branch of a conditional statement is a single<br>statement; in the latter case use braces in both branches" <a href="https://www.kernel.org/doc/Documentation/process/coding-style.rst" rel="noreferrer" target="_blank">https://www.kernel.org/doc/Documentation/process/coding-style.rst</a></div><div><br></div><div>So these hunk is fine.<br></div></div></div></div></div>