<div dir="ltr"><div class="gmail_quote"><div>Hi,<br></div><div><br></div><div>last time I touched this code we had some zdtm tests failing.</div><div><br></div><div>Have you checked how many tests/issues still need to be fixed?</div><div><br></div><div>cheers,</div><div>rodrigo</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">----------------------------------------------------------------------<br>
<br>
Message: 1<br>
Date: Sat, 8 Sep 2018 10:18:27 +0100<br>
From: Radostin Stoyanov <<a href="mailto:rstoyanov1@gmail.com" target="_blank">rstoyanov1@gmail.com</a>><br>
To: CRIU <<a href="mailto:criu@openvz.org" target="_blank">criu@openvz.org</a>><br>
Subject: [CRIU] Image cache/proxy TODO<br>
Message-ID: <<a href="mailto:3ddf274f-54a7-b947-fa25-a9c3d60b9fb4@gmail.com" target="_blank">3ddf274f-54a7-b947-fa25-a9c3d60b9fb4@gmail.com</a>><br>
Content-Type: text/plain; charset="utf-8"<br>
<br>
Hi all,<br>
<br>
I would like to work towards merging the remote option and image<br>
cache/proxy into<br>
the master branch of CRIU and I was wondering what needs to be done?<br>
<br>
Below is a brief summary of the tasks from [1] and the commit comment in<br>
[2].<br>
<br>
1. Add articles for newly introduced actions and options.<br>
- I assume that this task is to add more information to the following pages<br>
* <a href="https://criu.org/CLI/opt/--remote" rel="noreferrer" target="_blank">https://criu.org/CLI/opt/--remote</a><br>
* <a href="https://criu.org/CLI/cmd/image-cache" rel="noreferrer" target="_blank">https://criu.org/CLI/cmd/image-cache</a><br>
* <a href="https://criu.org/CLI/cmd/image-proxy" rel="noreferrer" target="_blank">https://criu.org/CLI/cmd/image-proxy</a><br>
<br>
2. Make the UNIX sockets reside in work-dir.<br>
- The option -D|--images-dir should become optional. When --remote is used,<br>
CRIU should work purely on the work-dir and not generate anything in the<br>
images-dir.<br>
<br>
3. Tune up the image_cache and image_proxy commands to accept the<br>
--status-fd<br>
and --pidfile options.<br>
<br>
4. Fix local connections not to generate per-image threads.<br>
- I believe that this one is already done.<br>
<br>
5. No strings in protocol. Now the hard-coded "RESTORE_FINISH" string<br>
(and DUMP_FINISHED one) is used to terminate the communication.<br>
Need to tune up the protobuf objects to send boolean (or integer) EOF<br>
sign rather that the string.<br>
<br>
6. Check how proxy/cache works with incremental dumps.<br>
<br>
7. Add support for cache/proxy into go-phaul code.<br>
<br>
Is there anything else?<br>
<br>
[1] <a href="https://criu.org/Image_cache/proxy_TODO" rel="noreferrer" target="_blank">https://criu.org/Image_cache/proxy_TODO</a><br>
[2]<br>
<a href="https://github.com/checkpoint-restore/criu/commit/a14f0d0effc92985a79a9a9da86e338b968c26d6" rel="noreferrer" target="_blank">https://github.com/checkpoint-restore/criu/commit/a14f0d0effc92985a79a9a9da86e338b968c26d6</a><br>
<br>
Thanks,<br>
Radostin<br>
<br>
<br>
------------------------------<br>
</blockquote></div></div>