<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Fri, Aug 17, 2018 at 3:00 AM Andrey Vagin <<a href="mailto:avagin@virtuozzo.com">avagin@virtuozzo.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Sat, Apr 28, 2018 at 12:56:40PM +0300, Cyrill Gorcunov wrote:<br>
> The test case may consume more than 5 seconds depending<br>
> on the node load, for this sake we introduce ZDTM_DELTA<br>
> variable (see ae48b5d676e90e998cf6b12d3a36d5f73c45f5ea)<br>
> but actually there was no way to setup it in our vanilla<br>
> zdtm.py engine earlier. Now we can do that so setup the<br>
> limit up to one minute, thus if it trigger it is definitely<br>
> something goes wrong.<br>
> <br>
> <a href="https://ci.openvz.org/view/CRIU/job/CRIU/job/CRIU-snap/job/criu-dev/3717/consoleFull" rel="noreferrer" target="_blank">https://ci.openvz.org/view/CRIU/job/CRIU/job/CRIU-snap/job/criu-dev/3717/consoleFull</a><br>
> <a href="https://ci.openvz.org/view/CRIU/job/CRIU/job/CRIU-x86_64-pre-dump/job/criu-dev/3724/consoleFull" rel="noreferrer" target="_blank">https://ci.openvz.org/view/CRIU/job/CRIU/job/CRIU-x86_64-pre-dump/job/criu-dev/3724/consoleFull</a><br>
> <br>
> Signed-off-by: Cyrill Gorcunov <<a href="mailto:gorcunov@gmail.com" target="_blank">gorcunov@gmail.com</a>><br>
> ---<br>
> test/zdtm/static/poll.desc | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> <br>
> diff --git a/test/zdtm/static/poll.desc b/test/zdtm/static/poll.desc<br>
> index 63df42aa670a..f8bce6e5d61b 100644<br>
> --- a/test/zdtm/static/poll.desc<br>
> +++ b/test/zdtm/static/poll.desc<br>
> @@ -1 +1 @@<br>
> -{'flavor': 'h'}<br>
> +{'flavor': 'h', 'env': 'ZDTM_DELTA=60'}<br>
<br>
gettimeofday(&time1, NULL)<br>
poll(ufds, 2, delta * 1000);<br>
gettimeofday(&time2, NULL)<br>
<br>
if ((time2.tv_sec - time1.tv_sec) > delta) {<br>
fail("Delta is too big %lu",<br>
(unsigned long)(time2.tv_sec - time1.tv_sec));<br>
<br>
<br>
I don't understand how this patch fixes the problem. It is obvious that<br>
time2 - time1 is greater than delta. Maybe we need to take into account<br>
some inaccuracy?<br></blockquote><div><br></div><div>This is mostly for vz7 instance of testing where we have time virtualized. I'll review more detailed tomorrow and reply. Sorry for delay.</div></div></div>