<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
On 14/06/18 20:11, Radostin Stoyanov wrote:<br>
<blockquote type="cite"
cite="mid:d66ba0a6-86d0-ea64-f657-e3546346e191@gmail.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<tt>Hi Adrian,</tt><tt><br>
</tt><tt><br>
</tt><tt>I saw similar errors for the test on fedora rawhide</tt><tt>
in</tt><tt><br>
</tt><tt> </tt><tt><a class="moz-txt-link-freetext"
href="https://travis-ci.org/criupatchwork/criu/jobs/392132369#L2281"
moz-do-not-send="true">https://travis-ci.org/criupatchwork/criu/jobs/392132369#L2281</a></tt><tt><br>
</tt><tt><br>
</tt>
<div class="log-line"><tt><span id="0-3149">In file included from
/usr/include/asm/signal.h:26,</span></tt></div>
<div class="log-line"><tt><span id="0-3150"> from
/usr/include/linux/signal.h:5,</span></tt></div>
<div class="log-line"><tt><span id="0-3151"> from
/usr/include/linux/aio_abi.h:32,</span></tt></div>
<div class="log-line"><tt><span id="0-3152"> from
criu/include/aio.h:4,</span></tt></div>
<div class="log-line"><tt><span id="0-3153"> from
criu/pie/parasite.c:22:</span></tt></div>
<div class="log-line"><tt><span id="0-3154">/usr/include/asm-generic/signal.h:92:3:
error: conflicting types for 'sigset_t'</span></tt></div>
<div class="log-line"><tt><span id="0-3155"> } sigset_t;</span></tt></div>
<div class="log-line"><tt><span id="0-3156"> ^~~~~~~~</span></tt></div>
<tt><br>
</tt><tt>I think this issue can be fixed with:<br>
</tt><br>
</blockquote>
<tt>diff --git a/criu/pie/parasite.c b/criu/pie/parasite.c<br>
index b9dae3f9..5f3bed96 100644<br>
--- a/criu/pie/parasite.c<br>
+++ b/criu/pie/parasite.c<br>
@@ -1,6 +1,5 @@<br>
#include <sys/mman.h><br>
#include <errno.h><br>
-#include <signal.h><br>
#include <linux/limits.h><br>
#include <linux/capability.h><br>
#include <sys/mount.h><br>
<br>
(send the wrong diff in previous email)<br>
</tt>
<blockquote type="cite"
cite="mid:d66ba0a6-86d0-ea64-f657-e3546346e191@gmail.com"><tt> <br>
<br>
Kind regards,<br>
Radostin</tt><font face="Helvetica, Arial, sans-serif"><br>
<br>
</font>
<div class="moz-cite-prefix">On 14/06/18 19:20, Adrian Reber
wrote:<br>
</div>
<blockquote type="cite" cite="mid:20180614182003.GD31373@lisas.de">
<pre wrap="">As I see it also in travis (<a class="moz-txt-link-freetext" href="https://api.travis-ci.org/v3/job/392077603/log.txt" moz-do-not-send="true">https://api.travis-ci.org/v3/job/392077603/log.txt</a>)
I guess it is known that currently compilation fails on early 4.18
kernels.
CC criu/pie/parasite.o
In file included from /usr/include/asm/signal.h:7,
from /usr/include/linux/signal.h:5,
from /usr/include/linux/aio_abi.h:32,
from criu/include/aio.h:4,
from criu/pie/parasite.c:22:
/usr/include/linux/time.h:10:8: error: redefinition of ‘struct timespec’
(and more)
Is this a bug in the kernel or does it need a fix in CRIU? Just curious
if somebody is looking into it?
Adrian
_______________________________________________
CRIU mailing list
<a class="moz-txt-link-abbreviated" href="mailto:CRIU@openvz.org" moz-do-not-send="true">CRIU@openvz.org</a>
<a class="moz-txt-link-freetext" href="https://lists.openvz.org/mailman/listinfo/criu" moz-do-not-send="true">https://lists.openvz.org/mailman/listinfo/criu</a>
</pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>