<div dir="ltr"> We can have number of processes with same start time and same pid as fork is fast enough. What is predump start_time? If you mean process' start time we don't save it in predump and it will require separate image for it.<br>
</div><div dir="ltr"><br>
</div><div dir="ltr"><br>
</div><div dir="ltr"><br>
</div><div class="wps_signature">Best regards, Tikhomirov Pavel.</div><div class="wps_quotion">Dmitry Safonov <0x7f454c46@gmail.com> | От: 9 февр. 2018 г. 19:34 | Сообщение:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><p></p><p dir="ltr">2018-02-09 16:06 GMT+00:00 Pavel Tikhomirov <<a href="mailto:ptikhomirov@virtuozzo.com">ptikhomirov@virtuozzo.com</a>>:
<br>
> We want to use a simple fact: If we have an alive process in a pstree we
<br>
> want to dump, and a starttime of that process is less than pre-dump's
<br>
> timestamp, then these exact process existed (100% sure) at the time of
<br>
> these pre-dump and the process' memory was dumped in images. Thus we
<br>
> save uptime while in freezed state else these won't work.
<br>
>
<br>
> <a href="https://jira.sw.ru/browse/PSBM-67502">https://jira.sw.ru/browse/PSBM-67502</a>
<br>
>
<br>
> Signed-off-by: Pavel Tikhomirov <<a href="mailto:ptikhomirov@virtuozzo.com">ptikhomirov@virtuozzo.com</a>>
<br>
> ---
<br>
> criu/cr-dump.c | 4 ++++
<br>
> criu/include/stats.h | 2 ++
<br>
> criu/proc_parse.c | 2 +-
<br>
> criu/stats.c | 22 ++++++++++++++++++++++
<br>
> images/stats.proto | 2 ++
<br>
> 5 files changed, 31 insertions(+), 1 deletion(-)
<br>
<br>
The commit message doesn't answer, why we need uptime at all.
<br>
ITOW, why checking of start_time from procfs you use to compare
<br>
with uptime can't be used to check if process is the same:
<br>
pre-dump-1's start_time == pre-dump-2's start_time
<br>
<br>
I'm not against, just wonder why we need additionally save uptime in
<br>
image files to what we already have..
<br>
<br>
--
<br>
Dmitry
<br>
</p>
</blockquote></div>