<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=koi8-r">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p></p>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; margin-top: 0px; margin-bottom: 0px;">
Sorry, my bad. I've got things mixed up and I've misdescribed the problem in commit message. In fact, problem was opposite to that. pidfiles actually contain no newlines. As seen in test.c, pids are written like that:</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; margin-top: 0px; margin-bottom: 0px;">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; margin-top: 0px; margin-bottom: 0px;">
dprintf(fd, "%d", pid)</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; margin-top: 0px; margin-bottom: 0px;">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 16px; margin-top: 0px; margin-bottom: 0px;">
Hence, "cat *.pid" would produce a single undelimited string of numbers, like 1000110002100031000410005... and kill would obviously fail. It's possible to modify test.c instead to print newline after the pid. Then we would have no need to modify Makefiles.
I used awk to print pids separated instead, to avoid editing the zdtm lib.</div>
<p></p>
<br>
<br>
<div style="color: rgb(0, 0, 0);">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>От:</b> Pavel Emelianov<br>
<b>Отправлено:</b> 25 ноября 2016 г. 17:59<br>
<b>Кому:</b> Cyrill Gorcunov; crml<br>
<b>Копия:</b> Vitaly Ostrosablin; Andrey Vagin<br>
<b>Тема:</b> Re: [CRIU] [PATCH 1/3] tests: replace cat in Makefiles with awk</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">On 11/25/2016 05:19 PM, Cyrill Gorcunov wrote:<br>
> From: Vitaly Ostrosablin <vostrosablin@virtuozzo.com><br>
> <br>
> cat outputs pidfiles with newlines at end,<br>
> while we need them to be unsplitted for kill<br>
> command to work.<br>
<br>
What's the environment in which kill doesn't work with \n-s?<br>
<br>
> Signed-off-by: Vitaly Ostrosablin <vostrosablin@virtuozzo.com><br>
> Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org><br>
> ---<br>
> test/zdtm/static/Makefile | 4 ++--<br>
> test/zdtm/transition/Makefile | 4 ++--<br>
> 2 files changed, 4 insertions(+), 4 deletions(-)<br>
> <br>
> diff --git a/test/zdtm/static/Makefile b/test/zdtm/static/Makefile<br>
> index 6d8cd755fe22..4bafc10e373a 100644<br>
> --- a/test/zdtm/static/Makefile<br>
> +++ b/test/zdtm/static/Makefile<br>
> @@ -342,7 +342,7 @@ start: $(PID) $(STATE)<br>
> check_start: $(PID:%.pid=%.is_running)<br>
> <br>
> stop: $(STATE_OUT)<br>
> - -kill -TERM `cat *.pid`<br>
> + -kill -TERM `awk '{print}' *.pid`<br>
> <br>
> WAIT_TIME=240<br>
> %.stop: %.pid %<br>
> @@ -360,7 +360,7 @@ WAIT_TIME=240<br>
> wait_stop:<br>
> i=0; \<br>
> while [ $$i -lt $(WAIT_TIME) ] ; do \<br>
> - kill -0 `cat *.pid 2>/dev/null` 2>/dev/null || break; \<br>
> + kill -0 `awk '{print}' *.pid 2>/dev/null` 2>/dev/null || break; \<br>
> sleep 1; \<br>
> i=`expr $$i + 1`; \<br>
> done<br>
> diff --git a/test/zdtm/transition/Makefile b/test/zdtm/transition/Makefile<br>
> index 8e82070f81e5..a5ca99fa215f 100644<br>
> --- a/test/zdtm/transition/Makefile<br>
> +++ b/test/zdtm/transition/Makefile<br>
> @@ -65,12 +65,12 @@ start: $(PID)<br>
> check_start: $(PID:%.pid=%.is_running)<br>
> <br>
> stop:<br>
> - -kill -TERM `cat *.pid`<br>
> + -kill -TERM `awk '{print}' *.pid`<br>
> <br>
> WAIT_TIME=10<br>
> wait_stop:<br>
> -for i in `seq 1 $(WAIT_TIME)`; do \<br>
> - kill -0 `cat *.pid 2>/dev/null` 2>/dev/null || break; \<br>
> + kill -0 `awk '{print}' *.pid 2>/dev/null` 2>/dev/null || break; \<br>
> sleep 1; \<br>
> done<br>
> <br>
> <br>
<br>
</div>
</span></font></div>
</div>
</body>
</html>