<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Sep 16, 2016 at 1:46 PM, Andrei Vagin <span dir="ltr"><<a href="mailto:avagin@virtuozzo.com" target="_blank">avagin@virtuozzo.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Wed, Sep 14, 2016 at 05:06:15PM +0200, Adrian Reber wrote:<br>
> On Wed, Sep 14, 2016 at 05:45:49AM -0700, Andrei Vagin wrote:<br>
> > On Mon, Sep 12, 2016 at 07:41:29PM +0200, Adrian Reber wrote:<br>
> > > I was trying to checkpoint and restore a runc container and so far I had<br>
> > > two smaller problems. My runc container has<br>
> > ><br>
> > > "terminal": false<br>
> > ><br>
> > > and I am starting it detached '-d'. Checkpointing this container fails<br>
> > > if I run 'runc checkpoint --shell-job test' or without '--shell-job'<br>
> > > with following error:<br>
> > ><br>
> > > (00.003008) 29213 fdinfo 0: pos: 0x 0 flags: 102002/0<br>
> > > (00.003022) tty: Dumping tty 8 with id 0x7<br>
> > > (00.003026) Error (files-reg.c:1141): Can't lookup mount=22 for fd=0 path=/dev/pts/2<br>
> > > (00.003029) ------------------------------<wbr>----------<br>
> > > (00.003071) Error (cr-dump.c:1296): Dump files (pid: 29213) failed with -1<br>
> > ><br>
> > > I get the same error using criu-2.4 and latest master. If I start the<br>
> > > container without '-d' I can checkpoint it without any problem.<br>
> ><br>
> > Could you try to run ./runc ... &> /dev/null < /dev/null? Will it help?<br>
><br>
> Yes, that works.<br>
><br>
> > Could you show lsof -p for an init process of a container?<br>
><br>
> This is without the /dev/null redirection you suggested:<br>
><br>
> COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME<br>
> start 7464 root cwd DIR 252,1 4096 9129255 /<br>
> start 7464 root rtd DIR 252,1 4096 9129255 /<br>
> start 7464 root txt REG 252,1 960376 192967906 /usr/bin/bash<br>
> start 7464 root mem REG 252,1 193825299 /usr/lib64/<a href="http://libnss_files-2.17.so" rel="noreferrer" target="_blank">libnss_files-2.17.<wbr>so</a> (path inode=16885464)<br>
> start 7464 root mem REG 252,1 193773498 /usr/lib64/<a href="http://libc-2.17.so" rel="noreferrer" target="_blank">libc-2.17.so</a> (path inode=16883722)<br>
> start 7464 root mem REG 252,1 193825248 /usr/lib64/<a href="http://libdl-2.17.so" rel="noreferrer" target="_blank">libdl-2.17.so</a> (path inode=16884707)<br>
> start 7464 root mem REG 252,1 193825325 /usr/lib64/libtinfo.so.5.9 (path inode=16860633)<br>
> start 7464 root mem REG 252,1 193773472 /usr/lib64/<a href="http://ld-2.17.so" rel="noreferrer" target="_blank">ld-2.17.so</a> (path inode=16820578)<br>
> start 7464 root 0u CHR 136,2 0t0 5 /dev/pts/2<br>
> start 7464 root 1u CHR 136,2 0t0 5 /dev/pts/2<br>
> start 7464 root 2u CHR 136,2 0t0 5 /dev/pts/2<br>
> start 7464 root 255r REG 252,1 83 8550670 /start<br>
><br>
><br>
> > > Another problem I have seen is using runc with<br>
> > ><br>
> > > "readonly": true<br>
> > ><br>
> > > this gives me following error:<br>
> > ><br>
> > > (00.079785) Dumping task cwd id 0xb root id 0xb<br>
> > > (00.079931) mnt: Dumping mountpoints<br>
> > > (00.079934) mnt: 213: 2b:/null @ ./proc/sched_debug<br>
> > > (00.079934) mnt: Something is mounted on top of ./dev<br>
> > > (00.080004) Error (criu/mount.c:1044): mnt: Can't create a temporary directory: Read-only file system<br>
> ><br>
> > It's known issue. Yesterday I started to rework mount.c to support this<br>
> > case. I will try to prepare draft patches before Friday.<br>
><br>
> Great, good to know.<br>
<br>
I pushed my changes on github, but I don't test them with runc.<br>
<a href="https://github.com/avagin/criu/commits/mntns_for_adrian" rel="noreferrer" target="_blank">https://github.com/avagin/<wbr>criu/commits/mntns_for_adrian</a></blockquote><div><br></div><div>I can give it a try and let u know how it goes Andrei.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
><br>
> Adrian<br>
______________________________<wbr>_________________<br>
CRIU mailing list<br>
<a href="mailto:CRIU@openvz.org">CRIU@openvz.org</a><br>
<a href="https://lists.openvz.org/mailman/listinfo/criu" rel="noreferrer" target="_blank">https://lists.openvz.org/<wbr>mailman/listinfo/criu</a><br>
</blockquote></div><br></div></div>