<div dir="ltr">Oh yep. Dedup is about punching holes in old images. Thank you.<div>I've spot a bug in my patchset that appeared after rebasing onto fresh criu-dev.</div><div>I'll send fixed and improved patch set very soon.</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-08-11 17:11 GMT+03:00 Pavel Emelyanov <span dir="ltr"><<a href="mailto:xemul@virtuozzo.com" target="_blank">xemul@virtuozzo.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 08/11/2016 04:56 PM, Eugene Batalov wrote:<br>
> When we track changes since last dump we don't dump not changed pages so we don't create<br>
> duplicates of pages on each criu dump.<br>
<br>
</span>O_o Well, we don't create this even now.<br>
So the patch title should rather be "Pre-dump anon shared memory"?<br>
<span class=""><br>
> This is not equal to full data deduplication but it is similar. Also "dedup" term is used<br>
> already (ex. --auto-dedup option) in criu --help.<br>
<br>
</span>Exactly! The dedup in criu is taking images and punching duplicate data from<br>
it, not ... doing something with pages RSS or SOFT_DIRTY detection :)<br>
<br>
> 2016-08-10 16:23 GMT+03:00 Pavel Emelyanov <<a href="mailto:xemul@virtuozzo.com">xemul@virtuozzo.com</a> <mailto:<a href="mailto:xemul@virtuozzo.com">xemul@virtuozzo.com</a>>>:<br>
<span class="">><br>
> Again, why dedup?! It's about changes tracking, isn't it?<br>
><br>
> On 08/07/2016 04:11 PM, Eugene Batalov wrote:<br>
> > As anon shmem dump supports dedup now<br>
> > we can work with it during predump.<br>
> ><br>
</span>> > Signed-off-by: Eugene Batalov <<a href="mailto:eabatalov89@gmail.com">eabatalov89@gmail.com</a> <mailto:<a href="mailto:eabatalov89@gmail.com">eabatalov89@gmail.com</a>><wbr>><br>
<div class="HOEnZb"><div class="h5">> > ---<br>
> > criu/cr-dump.c | 4 ++++<br>
> > 1 file changed, 4 insertions(+)<br>
> ><br>
> > diff --git a/criu/cr-dump.c b/criu/cr-dump.c<br>
> > index 743100d..f65002b 100644<br>
> > --- a/criu/cr-dump.c<br>
> > +++ b/criu/cr-dump.c<br>
> > @@ -1563,6 +1563,10 @@ int cr_pre_dump_tasks(pid_t pid)<br>
> > if (pre_dump_one_task(item))<br>
> > goto err;<br>
> ><br>
> > + ret = cr_dump_shmem();<br>
> > + if (ret)<br>
> > + goto err;<br>
> > +<br>
> > if (irmap_predump_prep())<br>
> > goto err;<br>
> ><br>
> ><br>
><br>
><br>
><br>
><br>
> --<br>
> Best regards,<br>
> Eugene Batalov.<br>
<br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Best regards,<br>Eugene Batalov.</div>
</div>