<p dir="ltr"><br>
On Jun 24, 2016 9:37 AM, "Andrei Vagin" <<a href="mailto:avagin@gmail.com">avagin@gmail.com</a>> wrote:<br>
><br>
> On Thu, Jun 23, 2016 at 10:45 PM, Mike Rapoport <<a href="mailto:mike.rapoport@gmail.com">mike.rapoport@gmail.com</a>> wrote:<br>
> ><br>
> > On Jun 24, 2016 4:23 AM, "Andrew Vagin" <<a href="mailto:avagin@virtuozzo.com">avagin@virtuozzo.com</a>> wrote:<br>
> >><br>
> >> On Thu, Jun 23, 2016 at 11:31:04AM +0300, Mike Rapoport wrote:<br>
> >> > Hi,<br>
> >> ><br>
> >> > I've been looking into reducing use of page-read internals outside<br>
> >> > the page-read.c and found something that seems really weird.<br>
> >> ><br>
> >> > If auto_dedup is enabled, the restore_shmem_content punches a hole in<br>
> >> > the pagemap image, but it never tries to read anything from the<br>
> >> > parent image. Moreover, open_page_read_at does not even bother to open<br>
> >> > parent image in case it opens shared memory image.<br>
> >> ><br>
> >> > If I understand correctly, if the hole is really punched, calling<br>
> >> > restore next time on the same set of images will fail.<br>
> >><br>
> >> if you use --auto-dedup, you are going to run restore only once<br>
> ><br>
> > And what if I'd like to use the same checkpoint directories once more, e.g.<br>
> > on another host?<br>
><br>
> Maybe you have to run criu without the --auto-dedup option in this case?</p>
<p dir="ltr">And what's the point of auto-dedup then? </p>
<p dir="ltr">> ><br>
> >> --auto-dedup when used on dump it will deduplicate "old" data<br>
> >> in<br>
> >> pages images of previous dump<br>
> >> when used on restore, as soon as page is restored,<br>
> >> it<br>
> >> will be punched from the image.<br>
> >><br>
> >> ><br>
> >> > Am I missing something?<br>
> >> ><br>
> >> > --<br>
> >> > Sincerely yours,<br>
> >> > Mike.<br>
> >> > _______________________________________________<br>
> >> > CRIU mailing list<br>
> >> > <a href="mailto:CRIU@openvz.org">CRIU@openvz.org</a><br>
> >> > <a href="https://lists.openvz.org/mailman/listinfo/criu">https://lists.openvz.org/mailman/listinfo/criu</a><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > CRIU mailing list<br>
> > <a href="mailto:CRIU@openvz.org">CRIU@openvz.org</a><br>
> > <a href="https://lists.openvz.org/mailman/listinfo/criu">https://lists.openvz.org/mailman/listinfo/criu</a><br>
> ><br>
</p>