<div dir="ltr"><div>About mnt namespaces. We call prepare_mnt_ns(). This does a bunch of things and gets to mount.c:</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">3185 ret = mnt_tree_for_each(pms, do_mount_one);</blockquote><div>I haven't implemented criu restore ever but one of the ways to implement mount namespace restore is to create its whole fs tree (with root mount point and all the submounts) then create new mnt ns, then enter it. then pivot root in it, then exit from ns. It looks like CRIU restore and particularly prepare_mnt_ns() does the same thing.</div><div><br></div><div>About networking. Look inside network_unlock_internal(). Our folk has missed its call and we'll add it to into our patch. This network_unlock_internal() calls switch_ns and restore_ns back with iptables manipulation between them.</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-05-16 20:55 GMT+03:00 Tycho Andersen <span dir="ltr"><<a href="mailto:tycho.andersen@canonical.com" target="_blank">tycho.andersen@canonical.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, May 16, 2016 at 08:47:26PM +0300, Batalov Eugene wrote:<br>
> Conceptually we're able to get the same state in criu gc as criu restore<br>
> gets.<br>
><br>
> I am agree about namespaces and network unlock. Our folk has missed this.<br>
><br>
> About link remaps and namespaces. This thing from patch looks like it<br>
> should working:<br>
><br>
> > + if (rfe->remap_type == REMAP_TYPE__LINKED) {<br>
> > + if (open_remap_linked(rfi, rfe))<br>
> > + {<br>
> > + pr_err("open_remap_linked failed");<br>
> > + return -1;<br>
> > + }<br>
> > +<br>
> > + int mntns_root = mntns_get_root_by_mnt_id(rfi->remap->rmnt_id);<br>
<br>
</span>Perhaps I'm missing something, but why is this mntns the same one as<br>
the task whose mount ns we're trying to clean?<br>
<br>
I can see that it might work because you pivot_root() into the same<br>
--root as the dump/restore is in, but if the container's root isn't<br>
mounted on the host won't that fail?<br>
<span class="HOEnZb"><font color="#888888"><br>
Tycho<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Eugene Batalov.</div>
</div>