<div dir="ltr"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span style="font-size:12.8px">It would be nice to have in the June CRIU release if possible. Is<br></span><span style="font-size:12.8px">there some way I can help you guys with the implementation?</span></blockquote><div>As I understand you probably have some real migration tests.</div><div>Could we ask you to apply our patch set and test it on your workloads when the patch set is ready?</div><div>It would take some time for us to make good tests. And the real workloads are better anyway.</div><div>It is hard to imagine another ways to help for now. The feature is quite small so it is hard to cut it into pieces.</div><div><br></div><div>Ok. We'll try to get in time with the feature.</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-05-16 17:48 GMT+03:00 Tycho Andersen <span dir="ltr"><<a href="mailto:tycho.andersen@canonical.com" target="_blank">tycho.andersen@canonical.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, May 16, 2016 at 05:38:05PM +0300, Batalov Eugene wrote:<br>
> ><br>
> > What I'm not sure about is how this works with<br>
> > --leave-running; doesn't it already delete these rules? If not, how is<br>
> > the network actually unlocked?<br>
><br>
><br>
> cr-dump.c: (opts.final_state == TASK_ALIVE if --leave-running is passed to<br>
> criu)<br>
> 1597 if (ret || post_dump_ret || opts.final_state == TASK_ALIVE) {<br>
> 1598 network_unlock();<br>
> 1599 delete_link_remaps();<br>
> 1600 }<br>
><br>
> The only problem is that this 2 function calls are executed after dump and<br>
> during restore.<br>
> And this calls expect already initialized big c/r state. It's the problem<br>
> that I've described in the previous email.<br>
><br>
> Also there is a pecularity in criu gc that can be important for you. You<br>
> need to specify path to image<br>
> files dir for criu gc because criu gc uses data from images to find the<br>
> right iptable rules and link remaps.<br>
> So a part of dump should be stored on node you migrate from.<br>
<br>
</span>I looked at this too, and using the images is a nice way to work<br>
around the fact that network_unlock() requires a lot of state. That<br>
will be fine for me.<br>
<span class=""><br>
> Tycho, do you have any urgency in criu gc feature arrival?<br>
<br>
</span>It would be nice to have in the June CRIU release if possible. Is<br>
there some way I can help you guys with the implementation?<br>
<span class="HOEnZb"><font color="#888888"><br>
Tycho<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Eugene Batalov.</div>
</div>