<div dir="ltr"><div>2016-05-16 21:48 GMT+03:00 Andrew Vagin <span dir="ltr"><<a href="mailto:avagin@virtuozzo.com" target="_blank">avagin@virtuozzo.com</a>></span>:<br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class=""><div class="h5">On Mon, May 02, 2016 at 06:46:05PM +0300, Eugene Batalov wrote:<br>
> From: Kravchenko Dmitrii <<a href="mailto:equivalence1@gmail.com">equivalence1@gmail.com</a>><br>
><br>
> This patch adds implementation of --leave-stopped option<br>
> to CRIU restore cmd. If --leave-stopped is passed then<br>
> each process in ps tree gets SIGSTOP before detaching<br>
> from it.<br>
><br>
> Signed-off-by: Kravchenko Dmitrii <<a href="mailto:equivalence1@gmail.com">equivalence1@gmail.com</a>><br>
> Signed-off-by: Eugene Batalov <<a href="mailto:eabatalov89@gmail.com">eabatalov89@gmail.com</a>><br>
> ---<br>
> criu/cr-restore.c | 3 ++-<br>
> criu/crtools.c | 10 ++++++++++<br>
> 2 files changed, 12 insertions(+), 1 deletion(-)<br>
><br>
> diff --git a/criu/cr-restore.c b/criu/cr-restore.c<br>
> index ac0943b..d212abe 100644<br>
> --- a/criu/cr-restore.c<br>
> +++ b/criu/cr-restore.c<br>
> @@ -1924,7 +1924,8 @@ static void finalize_restore(void)<br>
><br>
> xfree(ctl);<br>
><br>
> - if (item->pid.state == TASK_STOPPED)<br>
> + if ((item->pid.state == TASK_STOPPED) ||<br>
> + (opts.final_state == TASK_STOPPED))<br>
> kill(item->pid.real, SIGSTOP);<br>
> }<br>
> }<br>
> diff --git a/criu/crtools.c b/criu/crtools.c<br>
> index 7a0f977..be33f4c 100644<br>
> --- a/criu/crtools.c<br>
> +++ b/criu/crtools.c<br>
> @@ -688,6 +688,16 @@ int main(int argc, char *argv[], char *envp[])<br>
> return 1;<br>
> }<br>
><br>
> + /*<br>
> + * When a process group becomes an orphan,<br>
> + * its processes are sent a SIGHUP signal<br>
> + */<br>
> + if (!strcmp(argv[optind], "restore") &&<br>
> + opts.restore_detach &&<br>
> + opts.final_state == TASK_STOPPED &&<br>
> + opts.shell_job)<br>
> + pr_warn("Stopped and detached shell job will get SIGHUP from OS.");<br>
<br>
</div></div>Why does this specific for TASK_STOPPED?<br></blockquote><div><br></div><div>I've checked this thing better.</div><div>SIGHUP is only sent when a process is stopped. So I think my comment</div><div><span style="color:rgb(80,0,80)">> + /*</span><br style="color:rgb(80,0,80)"><span style="color:rgb(80,0,80)">> + * When a process group becomes an orphan,</span><br style="color:rgb(80,0,80)"><span style="color:rgb(80,0,80)">> + * its processes are sent a SIGHUP signal</span><br style="color:rgb(80,0,80)"><span style="color:rgb(80,0,80)">> + */</span><br></div><div>is not precise enough. Do you think we need to make it more precise?</div><div><br></div><div>Reference in POSIX to the subject: <a href="http://linux.die.net/man/2/getpgrp">http://linux.die.net/man/2/getpgrp</a><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">If the exit of the process causes a process group to become orphaned, and if any member of the newly orphaned process group is stopped, then a SIGHUP signal followed by a SIGCONT signal will be sent to each process in the newly orphaned process group. An orphaned process group is one in which the parent of every member of process group is either itself also a member of the process group or is a member of a process group in a different session</blockquote><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<span class="">> +<br>
> if (chdir(work_dir)) {<br>
> pr_perror("Can't change directory to %s", work_dir);<br>
> return 1;<br>
> --<br>
> 1.9.1<br>
><br>
</span>> _______________________________________________<br>
> CRIU mailing list<br>
> <a href="mailto:CRIU@openvz.org">CRIU@openvz.org</a><br>
> <a href="https://lists.openvz.org/mailman/listinfo/criu" rel="noreferrer" target="_blank">https://lists.openvz.org/mailman/listinfo/criu</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Eugene Batalov.</div>
</div></div>