<div dir="ltr">We've sent new version of the patchset yesterday. It should fix your comments.</div><div class="gmail_extra"><br><div class="gmail_quote">2015-12-09 11:25 GMT+03:00 Andrew Vagin <span dir="ltr"><<a href="mailto:avagin@virtuozzo.com" target="_blank">avagin@virtuozzo.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, Dec 08, 2015 at 03:38:27PM +0300, Pavel Emelyanov wrote:<br>
> On 11/26/2015 12:31 AM, Andrey Wagin wrote:<br>
> > 2015-11-24 16:34 GMT+03:00 Eugene Batalov <<a href="mailto:eabatalov89@gmail.com">eabatalov89@gmail.com</a>>:<br>
> >> Hello. This patchset implements c/r of ps tree<br>
> >> that was frozen using freezer controller before start of<br>
> >> ps tree dumping.<br>
> >> Such ps tree will be frozen after restore.<br>
> ><br>
> > Hi,<br>
> ><br>
> > Thank you for the patches. They look good at first glance. I will<br>
> > review them more carefully tomorrow.<br>
><br>
> So? :)<br>
<br>
</span>I have sent my commets as I promised.<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> > I want to suggest to add the --leave-frozen options to freeze<br>
> > processes after restoring even if they were not frozen before.<br>
> ><br>
> >> This means that we can c/r paused Docker containers.<br>
> >> See details in issue #20 on github:<br>
> >> <a href="https://github.com/xemul/criu/issues/20" rel="noreferrer" target="_blank">https://github.com/xemul/criu/issues/20</a><br>
> >><br>
> >> We'll send patch with autotest for this feature later.<br>
> >><br>
> >> From user point of view we extend functionality of --freeze-cgroup<br>
> >> option so CRIU documentation and help message for --freeze-cgroup<br>
> >> option may need some improvement/clarification.<br>
> >><br>
> >> Evgeniy Akimov (3):<br>
> >> cgroups: save freezer state during dump<br>
> >> restore: split finalize_restore into two stages<br>
> >> restore: restore freezer cgroup state<br>
> >><br>
> >> cgroup.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++++<br>
> >> cr-restore.c | 37 +++++++++++++++++++-----------<br>
> >> include/cgroup.h | 1 +<br>
> >> include/seize.h | 1 +<br>
> >> protobuf/cgroup.proto | 1 +<br>
> >> seize.c | 5 ++++<br>
> >> 6 files changed, 95 insertions(+), 13 deletions(-)<br>
> >><br>
> >> --<br>
> >> 1.9.1<br>
> >><br>
> >> _______________________________________________<br>
> >> CRIU mailing list<br>
> >> <a href="mailto:CRIU@openvz.org">CRIU@openvz.org</a><br>
> >> <a href="https://lists.openvz.org/mailman/listinfo/criu" rel="noreferrer" target="_blank">https://lists.openvz.org/mailman/listinfo/criu</a><br>
> > _______________________________________________<br>
> > CRIU mailing list<br>
> > <a href="mailto:CRIU@openvz.org">CRIU@openvz.org</a><br>
> > <a href="https://lists.openvz.org/mailman/listinfo/criu" rel="noreferrer" target="_blank">https://lists.openvz.org/mailman/listinfo/criu</a><br>
> > .<br>
> ><br>
><br>
> _______________________________________________<br>
> CRIU mailing list<br>
> <a href="mailto:CRIU@openvz.org">CRIU@openvz.org</a><br>
> <a href="https://lists.openvz.org/mailman/listinfo/criu" rel="noreferrer" target="_blank">https://lists.openvz.org/mailman/listinfo/criu</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Best regards,<br>Eugene Batalov.</div>
</div>