<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">2015-08-25 12:37 GMT+03:00 Pavel Emelyanov <span dir="ltr"><<a href="mailto:xemul@parallels.com" target="_blank">xemul@parallels.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 08/25/2015 10:50 AM, Artem Kuzmitskiy wrote:<br>
><br>
><br>
> 2015-08-21 20:57 GMT+03:00 Pavel Emelyanov <<a href="mailto:xemul@parallels.com">xemul@parallels.com</a> <mailto:<a href="mailto:xemul@parallels.com">xemul@parallels.com</a>>>:<br>
<span class="">><br>
> On 08/18/2015 06:32 PM, Artem Kuzmitskiy wrote:<br>
> > Hi all,<br>
> ><br>
> > I'm not sure what it's important, but I found that thread names (if were<br>
> > assigned using prctl\pthread_setname) not restored. Is it bug or not?<br>
><br>
> Well, if criu doesn't support something, then it's definitely a bug, but<br>
> we don't call it such. Not-yet-implemented-feature.<br>
><br>
> Ок.<br>
><br>
> > Steps for reproduce:<br>
> > 1. Start thread and assign name.<br>
> > pthread_create(&thread, NULL, do_nothing, NULL);<br>
> > pthread_setname_np(thread, "NOTHING_THREAD");<br>
> > 2. Check name using procfs<br>
> > $ cat /proc/12857/task/12858/stat<br>
> > 12858 (NOTHING_THREAD) .....<br>
> > 3. Dump process with this thread<br>
> > 4. Restore process<br>
> > 5. Check again<br>
> > cat /proc/12857/task/12858/stat<br>
> > 12858 (socketpair) .....<br>
> ><br>
> > P.S. In pstree.img not include the thread names now, only tid.<br>
><br>
> Yup. Patch for this is warmly welcome.<br>
><br>
> I feel that this is part of parasite code?<br>
<br>
</span>For restore -- yes, threads are restored in parasite, so name restore should also go there.<br>
<br>
</blockquote></div>On first look, these data may be inserted to pstree.img in threads section Am I right?<br><br>-----------<br># ../../../crit decode -i pstree.img <br>{"magic": "PSTREE", "entries": [{"pgid": 12857, "threads": [12857, 12858], "ppid": 0, "pid": 12857, "sid": 12857}]}<br>-----------<br><br></div><div class="gmail_extra"><br clear="all"><br>-- <br><div class="gmail_signature"><div dir="ltr"><div><div dir="ltr">Best regards,<div>Artem Kuzmitskiy</div><div><br></div></div></div></div></div>
</div></div>