<div dir="ltr"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 4, 2015 at 11:28 AM, Gabriel Guimaraes <span dir="ltr"><<a href="mailto:guimaraesg@google.com" target="_blank">guimaraesg@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5"><div dir="ltr"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Aug 4, 2015 at 10:39 AM, Gabriel Guimaraes <span dir="ltr"><<a href="mailto:guimaraesg@google.com" target="_blank">guimaraesg@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Pavel,<div><br></div><div>Filipe said I should create an open pull request, which is simpler:</div><div><br></div><div><a href="https://github.com/xemul/criu/pull/15" target="_blank">https://github.com/xemul/criu/pull/15</a><br></div><div><br></div><div>If you still want me to break down the patch and send you via email I can also do that.</div><div><br></div><div>Best,</div><div>Gabriel</div></div><div class="gmail_extra"><br><div class="gmail_quote"><span>On Tue, Aug 4, 2015 at 10:17 AM, Pavel Emelyanov <span dir="ltr"><<a href="mailto:xemul@parallels.com" target="_blank">xemul@parallels.com</a>></span> wrote:<br></span><div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span>On 08/03/2015 11:27 PM, Gabriel Guimaraes wrote:<br>
> Hi Pavel,<br>
><br>
> I believe Saied has already talked to you about this patch. It enables the --overlayfs flag in CRIU which<br>
> compensates for the OverlayFS bug in the Linux Kernel before version 4.2 (more about the bug at<br>
> <a href="http://criu.org/Docker" rel="noreferrer" target="_blank">http://criu.org/Docker</a>). More detailed information can be found in the patch itself.<br>
<br>
</span>Great :) But I see 3 patches inside. Would you split the e-mails too?<br>
<span><br>
> We did not implement a very sophisticated error checking mechanism, so an error such as "buffer too small"<br>
> within __lookup_overlayfs will be printed but won't necessarily make CRIU abort. If you'd like, we can<br>
> change that, but in my opinion this would make the code a lot more complicated with few gains, since it's<br>
> already easy to debug what error happened as is.<br>
<br>
</span>Sure, let's keep this simple all the more so this is a workaround that<br>
will go away soon.<br>
<span><font color="#888888"><br>
-- Pavel<br>
<br>
</font></span></blockquote></div></div></div><br></div>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>