<div dir="ltr"><p dir="ltr"><br>
On Mar 26, 2015 7:10 PM, "Oleg Nesterov" <<a href="mailto:oleg@redhat.com" target="_blank">oleg@redhat.com</a>> wrote:<br>
><br>
> validate_mounts() prints ->mnt_id in hex when it reports the failure.<br>
> This complicates the understanding because this ->mnt_id is printed as<br>
> decimal elsewhere, including /proc/$pid/mountinfo.<br>
><br>
> parse_mountinfo() adds "0x" at least and this is just pr_info(), but<br>
> lets change it too.<br>
></p>
<p dir="ltr">Acked-by: Andrew Vagin <<a href="mailto:avagin@openvz.org">avagin@openvz.org</a>></p><p dir="ltr">Thanks.</p><p dir="ltr"><br>
> Signed-off-by: Oleg Nesterov <<a href="mailto:oleg@redhat.com" target="_blank">oleg@redhat.com</a>><br>
> ---<br>
> mount.c | 2 +-<br>
> proc_parse.c | 2 +-<br>
> 2 files changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/mount.c b/mount.c<br>
> index e59cb0d..021c6e3 100644<br>
> --- a/mount.c<br>
> +++ b/mount.c<br>
> @@ -591,7 +591,7 @@ static int validate_mounts(struct mount_info *info, bool for_dump)<br>
><br>
> if (fsroot_mounted(m)) {<br>
> if (m->fstype->code == FSTYPE__UNSUPPORTED) {<br>
> - pr_err("FS mnt %s dev %#x root %s unsupported id %x\n",<br>
> + pr_err("FS mnt %s dev %#x root %s unsupported id %d\n",<br>
> m->mountpoint, m->s_dev, m->root, m->mnt_id);<br>
> return -1;<br>
> }<br>
> diff --git a/proc_parse.c b/proc_parse.c<br>
> index 8ad9d21..3009905 100644<br>
> --- a/proc_parse.c<br>
> +++ b/proc_parse.c<br>
> @@ -1009,7 +1009,7 @@ struct mount_info *parse_mountinfo(pid_t pid, struct ns_id *nsid)<br>
> goto err;<br>
> }<br>
><br>
> - pr_info("\ttype %s source %s mnt_id %#x s_dev %#x %s @ %s flags %#x options %s\n",<br>
> + pr_info("\ttype %s source %s mnt_id %d s_dev %#x %s @ %s flags %#x options %s\n",<br>
> fst ? : new->fstype->name, new->source,<br>
> new->mnt_id, new->s_dev, new->root, new->mountpoint,<br>
> new->flags, new->options);<br>
> --<br>
> 1.5.5.1<br>
><br>
><br>
</p>
</div>