<div dir="ltr">Sure, that would work. Will it then be the responsibility of the user to install it?<div><br></div><div>--Saied</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 5, 2014 at 8:43 AM, Pavel Emelyanov <span dir="ltr"><<a href="mailto:xemul@parallels.com" target="_blank">xemul@parallels.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 09/05/2014 07:00 PM, Saied Kazemi wrote:<br>
> Hi Pavel,<br>
><br>
> Thank you :) You're right, this script will eventually go away but for now it makes life much much<br>
> easier, reducing the command line arguments to at most one: the container ID.<br>
<br>
</span>Hm, OK. If you don't mind, I will relocate it to the contrib/ dir as Filipe suggested.<br>
<div class="HOEnZb"><div class="h5"><br>
> So one would simply do:<br>
><br>
> $ sudo docker_cr.sh -c<br>
> $ sudo docker_cr.sh -r<br>
><br>
> If the container ID is not specified on the command line, the script shows all containers and prompts the user to select the right one. When entering the ID, only enough characters to uniquely identify the container is needed. The -v flag can be optionally specified to enable verbose mode.<br>
><br>
> Without this script, one would have to invoke criu as follows to checkpoint:<br>
><br>
> $ sudo criu dump -o dump.log -v4 -t 17810 \<br>
> -D /tmp/img/<container_id> \<br>
> --root /var/lib/docker/aufs/mnt/<container_id> \<br>
> --ext-mount-map /etc/resolv.conf:/etc/resolv.conf \<br>
> --ext-mount-map /etc/hosts:/etc/hosts \<br>
> --ext-mount-map /etc/hostname:/etc/hostname \<br>
> --ext-mount-map /.dockerinit:/.dockerinit \<br>
> --manage-cgroups \<br>
> --evasive-devices<br>
><br>
> And to restore, one would have to set up the filesystem first and then invoke criu as follows:<br>
><br>
> $ sudo mount -t aufs -o br=\<br>
> /var/lib/docker/aufs/diff/<container_id>:\<br>
> /var/lib/docker/aufs/diff/<container_id>-init:\<br>
> /var/lib/docker/aufs/diff/a9eb172552348a9a49180694790b33a1097f546456d041b6e82e4d7716ddb721:\<br>
> /var/lib/docker/aufs/diff/120e218dd395ec314e7b6249f39d2853911b3d6def6ea164ae05722649f34b16:\<br>
> /var/lib/docker/aufs/diff/42eed7f1bf2ac3f1610c5e616d2ab1ee9c7290234240388d6297bc0f32c34229:\<br>
> /var/lib/docker/aufs/diff/511136ea3c5a64f264b78b5433614aec563103b4d4702f3ba7d4d2698e22c158:\<br>
> none /var/lib/docker/aufs/mnt/<container_id><br>
><br>
> $ sudo criu restore -o restore.log -v4 -d<br>
> -D /tmp/img/<container_id> \<br>
> --root /var/lib/docker/aufs/mnt/<container_id> \<br>
> --ext-mount-map /etc/resolv.conf:/var/lib/docker/containers/<container_id>/resolv.conf \<br>
> --ext-mount-map /etc/hosts:/var/lib/docker/containers/<container_id>/hosts \<br>
> --ext-mount-map /etc/hostname:/var/lib/docker/containers/<container_id>/hostname \<br>
> --ext-mount-map /.dockerinit:/var/lib/docker/init/dockerinit-1.0.0 \<br>
> --manage-cgroups \<br>
> --evasive-devices<br>
><br>
> So I suggest that this script be installed along with criu.<br>
><br>
> If you agree, I can prepare additional material for the Docker HOWTO page to cover docker_cr.sh as well as AUFS and UnionFS support.<br>
><br>
> Cheers!<br>
><br>
> --Saied<br>
><br>
><br>
><br>
><br>
</div></div><span class="im HOEnZb">> On Fri, Sep 5, 2014 at 7:40 AM, Filipe Brandenburger <<a href="mailto:filbranden@google.com">filbranden@google.com</a> <mailto:<a href="mailto:filbranden@google.com">filbranden@google.com</a>>> wrote:<br>
><br>
> Hi Pavel,<br>
><br>
</span><div class="HOEnZb"><div class="h5">> On Fri, Sep 5, 2014 at 7:34 AM, Pavel Emelyanov <<a href="mailto:xemul@parallels.com">xemul@parallels.com</a> <mailto:<a href="mailto:xemul@parallels.com">xemul@parallels.com</a>>> wrote:<br>
> > Guys, it's really great work you did with Docker! Do you think that this<br>
> > script is better to be planted into criu sources? I thought that, since<br>
> > we restore container detached from dockerd, some work will be done on the<br>
> > Docker side, that that _it_ does all these preparations.<br>
><br>
> Yes, the intention is to integrate criu support into libcontainer next<br>
> (which should maybe solve the "detached after restore" issue) and then<br>
> finally add hooks to docker (so that you can use "docker dump" and<br>
> "docker restore"). At that point, we can probably obsolete this<br>
> script.<br>
><br>
> But while we worked on that, we can share this script that we have<br>
> been using to test it internally, so that we can make it easier for<br>
> others to try it as well :-)<br>
><br>
> If you think scripts/ is not the best location for this script, maybe<br>
> contrib/ would be good?<br>
><br>
> Cheers,<br>
> Filipe<br>
><br>
><br>
<br>
</div></div></blockquote></div><br></div>