<div dir="ltr">I didn't see it. I just thought the patch was ignoring some error, and was asking if that was OK.<div><br></div><div>Oh, you can use my name.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Sat, Jan 4, 2014 at 2:36 PM, Pavel Emelyanov <span dir="ltr"><<a href="mailto:xemul@parallels.com" target="_blank">xemul@parallels.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On 01/04/2014 11:32 PM, Neal Becker wrote:<br>
> I'm assuming that "can't collect mount tree" is harmless??<br>
<br>
</div>Where do you see it? I thought (from your previous mail) that the<br>
patch helped and criu check worked OK.<br>
<div class="im HOEnZb"><br>
><br>
> On Sat, Jan 4, 2014 at 2:31 PM, Neal Becker <<a href="mailto:ndbecker2@gmail.com">ndbecker2@gmail.com</a> <mailto:<a href="mailto:ndbecker2@gmail.com">ndbecker2@gmail.com</a>>> wrote:<br>
><br>
> sudo crtools check --ms<br>
> (00.081409) Warn (tun.c:55): Skipping tun support check<br>
> Looks good.<br>
><br>
> Patch did not apply, I used this:<br>
><br>
><br>
><br>
</div><div class="HOEnZb"><div class="h5">> On Sat, Jan 4, 2014 at 2:17 PM, Pavel Emelyanov <<a href="mailto:xemul@parallels.com">xemul@parallels.com</a> <mailto:<a href="mailto:xemul@parallels.com">xemul@parallels.com</a>>> wrote:<br>
><br>
> On 01/04/2014 11:07 PM, Neal Becker wrote:<br>
> > Here's another view, generated by ABRT (automatic bug reporting tool)<br>
> ><br>
> > Core was generated by `criu check --ms'.<br>
> > Program terminated with signal SIGSEGV, Segmentation fault.<br>
> > #0 mount_resolve_path (path=0xd812a0 "/home/nbecker/.gnupg/S.gpg-agent") at mount.c:141<br>
> > 141list_for_each_entry(c, &m->children, siblings) {<br>
> ><br>
> > Thread 1 (Thread 0x7f1b37434740 (LWP 13862)):<br>
> > #0 mount_resolve_path (path=0xd812a0 "/home/nbecker/.gnupg/S.gpg-agent") at mount.c:141<br>
> > __mptr = <optimized out><br>
> > pathlen = 32<br>
> > m = 0x0<br>
> > c = <optimized out><br>
><br>
> This one is helpful, thanks. Can you check whether this patch helps:<br>
><br>
> diff --git a/cr-check.c b/cr-check.c<br>
> index 064d286..6074bfe 100644<br>
> --- a/cr-check.c<br>
> +++ b/cr-check.c<br>
> @@ -541,6 +541,11 @@ int cr_check(void)<br>
> return -1;<br>
> }<br>
><br>
> + if (collect_mount_info(getpid())) {<br>
> + pr_err("Can't collect mount tree\n");<br>
> + return -1;<br>
> + }<br>
> +<br>
> ret |= check_map_files();<br>
> ret |= check_sock_diag();<br>
> ret |= check_ns_last_pid();<br>
><br>
><br>
> If it does, I will apply it. Do you mind having your name and e-mail in the<br>
> Reported-by: tag in the CRIU repository?<br>
><br>
> Thanks,<br>
> Pavel<br>
><br>
><br>
><br>
<br>
<br>
</div></div></blockquote></div><br></div>