<div dir="ltr">Pardon me. Will split this patch as it should be, if other patches are ok.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Dec 7, 2013 at 11:58 PM, Cyrill Gorcunov <span dir="ltr"><<a href="mailto:gorcunov@gmail.com" target="_blank">gorcunov@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Sat, Dec 07, 2013 at 02:48:09AM +0400, Ruslan Kuprieiev wrote:<br>
> We need ldflags-so to link libcriu with -lprotobuf-c flag<br>
> and rpc.pb-c.o to use RPC.<br>
><br>
> Signed-off-by: Ruslan Kuprieiev <<a href="mailto:kupruser@gmail.com">kupruser@gmail.com</a>><br>
<br>
</div>Ruslan, please next time do not squash changes related to "generic"<br>
make engine with some additional changes. IOW, this should be at<br>
least two patches<br>
<br>
1) make: Introduce ldflags variable to make engine<br>
2) make: lib -- Use ldflags variable<br>
<br>
(That said if Pavel is fine with rest of patches, I would leave<br>
this one as is, but next time please try to post such changes<br>
separated).<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><span style="color:rgb(0,0,255);font-family:Helvetica,Arial,sans-serif;font-size:12px;line-height:15px;text-align:justify;background-color:rgb(255,255,255)">Best Regards.</span><div style="text-align:justify">
<font color="#0000ff" face="Helvetica, Arial, sans-serif"><span style="font-size:12px;line-height:15px">Kupreev Ruslan.</span></font></div>
</div>