[CRIU] [PATCH 1/9] Moved functions from parasite-syscall.c and cr-restore.c

Mike Rapoport mike at linux.ibm.com
Tue Mar 17 13:37:13 MSK 2020


Hello,

On Mon, Mar 16, 2020 at 09:29:28PM +0530, prakriti goyal wrote:
> From: prakritigoyal19 <prakritigoyal19 at gmail.com>
> 
> Signed-off-by: prakritigoyal19 <prakritigoyal19 at gmail.com>
> Repo link: https://github.com/prakritigoyal19/criu/tree/sigactions

We are accepting pull requests for a while now, so you can use that if you
prefer.
If you would like to still send patches to the mailing list, please
consider adding --cover-letter option to 'git send-email'. This will
generate a message that is intended for overall description of the series.
Still, each commit (patch) in the series should have a clear description
why the change is performed and what is the change.
 
> ---
>  criu/include/sigaction.h | 38 ++++++++++++++++++++++++++++++++++++++
>  1 file changed, 38 insertions(+)
>  create mode 100644 criu/include/sigaction.h
> 
> diff --git a/criu/include/sigaction.h b/criu/include/sigaction.h
> new file mode 100644
> index 00000000..ceafade3
> --- /dev/null
> +++ b/criu/include/sigaction.h
> @@ -0,0 +1,38 @@
> +#ifndef __CR_SIGACTION_H__
> +#define __CR_SIGACTION_H__
> +
> +
> +#include <sys/un.h>
> +#include <sys/time.h>
> +
> +#include <unistd.h>
> +#include <inttypes.h>
> +
> +#include "parasite.h"
> +#include "parasite-syscall.h"
> +#include "pstree.h"
> +#include "sigframe.h" //TaskCoreEntry, SaEntry
> +
> +#include "image.h"
> +#include "img-remote.h"
> +#include "images/core.pb-c.h"
> +#include "images/sa.pb-c.h"
> +#include "infect.h"
> +#include "infect-rpc.h"
> +#include "parasite.h"
> +#include "util-pie.h"
> +
> +#include <compel/compel.h>
> +#include "restore.h"
> +#include "restorer.h"

Are all these headers really needed here?

> +
> +
> +
> +
> +extern rt_sigaction_t sigchld_act;
> +
> +int parasite_dump_sigacts_seized(struct parasite_ctl *ctl, struct pstree_item *item);
> +
> +int prepare_sigactions(CoreEntry *core);
> +
> +#endif
> -- 
> 2.17.1

-- 
Sincerely yours,
Mike.



More information about the CRIU mailing list